Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask location permission (fixes #43, #45, #48, #51) #46

Merged
merged 55 commits into from
Nov 13, 2021
Merged

Conversation

ComputerOnFire
Copy link
Member

@ComputerOnFire ComputerOnFire commented Oct 30, 2021

@ComputerOnFire
Copy link
Member Author

permission_handler can be upgraded back to 8.2.5 again once we fix #47

@ComputerOnFire
Copy link
Member Author

ComputerOnFire commented Nov 4, 2021

new permissions called BLUETOOTH_SCAN and BLUETOOTH_CONNECT is needed for Android 12 https://developer.android.com/guide/topics/connectivity/bluetooth/permissions?hl=sl&skip_cache=true

@ComputerOnFire ComputerOnFire changed the title ask location permission (fixes #43, #45) ask location permission (fixes #43, #45, #48, #51) Nov 6, 2021
ios/Podfile Outdated
Comment on lines 38 to 41
installer.pods_project.targets.each do |target|
flutter_additional_ios_build_settings(target)
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ComputerOnFire we need to add permission here as well , other wise it will not work in IOS
eg:

post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      ... # Here are some configurations automatically generated by flutter

      # You can enable the permissions needed here. For example to enable camera
      # permission, just remove the `#` character in front so it looks like this:
      #
      # ## dart: PermissionGroup.camera
      # 'PERMISSION_CAMERA=1'
      #
      #  Preprocessor definitions can be found in: https://github.com/Baseflow/flutter-permission-handler/blob/master/permission_handler/ios/Classes/PermissionHandlerEnums.h
      config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= [
        '$(inherited)',

        ## dart: [PermissionGroup.location, PermissionGroup.locationAlways, PermissionGroup.locationWhenInUse]
        'PERMISSION_LOCATION=1',

      ]

    end
  end
end

@dogi dogi merged commit c78c887 into master Nov 13, 2021
@dogi dogi deleted the permissions branch November 13, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants