Support for ARM64 (Fixes #22) #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empeje
reviewed
Jun 12, 2018
.travis/travis_utils.sh
Outdated
| mv 2.1.1/Dockerfile-arm64 2.1.1/Dockerfile | ||
| if [ "$BRANCH" = "master" ] | ||
| then | ||
| sed -i -e "s|\(treehouses\/rpi-couchdb:2\.1\.1\)|$V211_DOCKER_NAME_LATEST|" 2.1.1/Dockerfile |
There was a problem hiding this comment.
sed is faster, but for OLE you create YAML on the fly, any specific reason not doing that what in this repo?
There was a problem hiding this comment.
no reason as such. This is how we used to do it before I found the method to create it on the fly. 😉
empeje
approved these changes
Jun 12, 2018
|
@empeje |
|
@empeje I have fix the conflicts and also removed the versions which can't be compiled. Since the version is updated to 2.1.2 and 1.7.2 we should first test them on |
|
Step to test:
|
|
Hi @dogi, hope you're doing good. Since I'm no longer working on the treehouses project, could you please unassign me from this MR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Support for ARM64
Testing recommendations
Multi-arch manifest pushed. Just use
treehouses/couchdbon aarm64device and it will run.To access 64Bit specifically use:
treehouses/rpi-couchdb:arm64-2.1.1-0.0.1-add-arm64-support-5a2b63caGitHub issue number
(Fixes #22)
Related Pull Requests
N/A
Checklist