Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim patch versions from lakeFSFS / lakeFS compatibility tests vector #8300

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

arielshaqed
Copy link
Contributor

Test only the latest patch version of every minor 1.x release

For any minor version, only the latest patch version needs to keep running
with with lakeFS. After all: suppose a new lakeFSFS version does not work
with a lakeFS minor version. If this were an issue, then we would release
some patch release for that lakeFS version.

This brings lakeFSFS support closer to that of any other lakeFS client: we
keep compatibility through the API and to fix any server-side breakages, a
new patch release.

Part of #8299, but not all of it.

@arielshaqed
Copy link
Contributor Author

Tips for future would-be reviewers: please review each commit separately. The first commit only reformats YAML, making the second commit easier to review.

@arielshaqed arielshaqed added area/API Improvements or additions to the API include-changelog PR description should be included in next release changelog area/client/hadoopfs area/ci labels Oct 23, 2024
@arielshaqed arielshaqed changed the base branch from master to N-o-Z-patch-6 October 23, 2024 06:34
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Copy link

E2E Test Results - Quickstart

11 passed

@arielshaqed arielshaqed changed the title Chore/8299 trim compatibility patch versions Trim patch versions from lakeFSFS / lakeFS compatibility tests vector Oct 23, 2024
Base automatically changed from N-o-Z-patch-6 to master October 23, 2024 11:27
@arielshaqed arielshaqed force-pushed the chore/8299-trim-compatibility-patch-versions branch from 6dff91d to 682e382 Compare October 27, 2024 12:15
@arielshaqed arielshaqed requested a review from N-o-Z October 27, 2024 12:19
@arielshaqed arielshaqed marked this pull request as ready for review October 27, 2024 12:21
@arielshaqed arielshaqed requested a review from itaiad200 October 28, 2024 09:24
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's getting _really_ long.  Also correct the comment about what being on
the list actually means.

Relevant to #8299.  Resolves one portion of it.

Rebased to include 1.40.0.
For any minor version, only the latest patch version needs to keep running
with with lakeFS.  After all: suppose a new lakeFSFS version does not work
with a lakeFS minor version.  If this were an issue, then we would release
some patch release for that lakeFS version.

This brings lakeFSFS support closer to that of any other lakeFS client: we
keep compatibility through the API and to fix any server-side breakages, a
new patch release.

Part of #8299, but not all of it.
@arielshaqed arielshaqed force-pushed the chore/8299-trim-compatibility-patch-versions branch from 682e382 to 08609ad Compare October 31, 2024 15:26
@arielshaqed arielshaqed enabled auto-merge (squash) October 31, 2024 15:27
@arielshaqed arielshaqed merged commit e50348e into master Oct 31, 2024
38 checks passed
@arielshaqed arielshaqed deleted the chore/8299-trim-compatibility-patch-versions branch October 31, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API Improvements or additions to the API area/ci area/client/hadoopfs include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lakeFSFS compatbility test: Test only the latest patch version of each minor release
3 participants