-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim patch versions from lakeFSFS / lakeFS compatibility tests vector #8300
Merged
arielshaqed
merged 2 commits into
master
from
chore/8299-trim-compatibility-patch-versions
Oct 31, 2024
Merged
Trim patch versions from lakeFSFS / lakeFS compatibility tests vector #8300
arielshaqed
merged 2 commits into
master
from
chore/8299-trim-compatibility-patch-versions
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tips for future would-be reviewers: please review each commit separately. The first commit only reformats YAML, making the second commit easier to review. |
arielshaqed
added
area/API
Improvements or additions to the API
include-changelog
PR description should be included in next release changelog
area/client/hadoopfs
area/ci
labels
Oct 23, 2024
arielshaqed
changed the title
Chore/8299 trim compatibility patch versions
Trim patch versions from lakeFSFS / lakeFS compatibility tests vector
Oct 23, 2024
arielshaqed
force-pushed
the
chore/8299-trim-compatibility-patch-versions
branch
from
October 27, 2024 12:15
6dff91d
to
682e382
Compare
itaiad200
approved these changes
Oct 28, 2024
N-o-Z
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's getting _really_ long. Also correct the comment about what being on the list actually means. Relevant to #8299. Resolves one portion of it. Rebased to include 1.40.0.
For any minor version, only the latest patch version needs to keep running with with lakeFS. After all: suppose a new lakeFSFS version does not work with a lakeFS minor version. If this were an issue, then we would release some patch release for that lakeFS version. This brings lakeFSFS support closer to that of any other lakeFS client: we keep compatibility through the API and to fix any server-side breakages, a new patch release. Part of #8299, but not all of it.
arielshaqed
force-pushed
the
chore/8299-trim-compatibility-patch-versions
branch
from
October 31, 2024 15:26
682e382
to
08609ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/API
Improvements or additions to the API
area/ci
area/client/hadoopfs
include-changelog
PR description should be included in next release changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test only the latest patch version of every minor 1.x release
For any minor version, only the latest patch version needs to keep running
with with lakeFS. After all: suppose a new lakeFSFS version does not work
with a lakeFS minor version. If this were an issue, then we would release
some patch release for that lakeFS version.
This brings lakeFSFS support closer to that of any other lakeFS client: we
keep compatibility through the API and to fix any server-side breakages, a
new patch release.
Part of #8299, but not all of it.