Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass context to async tasks to keep context fields intact #8320

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Pass context to async tasks to keep context fields intact #8320

merged 2 commits into from
Oct 30, 2024

Conversation

Jonathan-Rosenberg
Copy link
Contributor

Closes #8319

Details in the issue

@Jonathan-Rosenberg Jonathan-Rosenberg added the include-changelog PR description should be included in next release changelog label Oct 29, 2024
@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@github-actions GitHub Actions
Copy link

E2E Test Results - Quickstart

11 passed

@Jonathan-Rosenberg Jonathan-Rosenberg requested review from arielshaqed and removed request for arielshaqed October 29, 2024 13:09
N-o-Z
N-o-Z approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
One comment

pkg/catalog/catalog.go Outdated Show resolved Hide resolved
guy-har
guy-har approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@Jonathan-Rosenberg Jonathan-Rosenberg enabled auto-merge (squash) October 30, 2024 09:57
@Jonathan-Rosenberg Jonathan-Rosenberg merged commit 88495ce into master Oct 30, 2024
38 checks passed
@Jonathan-Rosenberg Jonathan-Rosenberg deleted the fix/import-hooks-context branch October 30, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guy-har guy-har guy-har approved these changes

@N-o-Z N-o-Z N-o-Z approved these changes

Assignees
No one assigned
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Importing fails if a pre commit hook is defined
3 participants
@Jonathan-Rosenberg @N-o-Z @guy-har