Raft #2219
Open
Raft #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Licenser
force-pushed
the
raft
branch
3 times, most recently
from
6439ac0
to
11c1cd1
Compare
Licenser
force-pushed
the
raft
branch
5 times, most recently
from
491a903
to
6d4770c
Compare
Licenser
force-pushed
the
raft
branch
8 times, most recently
from
4c22696
to
8e44885
Compare
Licenser
force-pushed
the
raft
branch
2 times, most recently
from
035e39b
to
9225326
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2219 +/- ##
===========================================
+ Coverage 54.01% 89.77% +35.75%
===========================================
Files 271 303 +32
Lines 39619 63917 +24298
===========================================
+ Hits 21401 57379 +35978
+ Misses 18218 6538 -11680
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 108 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Licenser
force-pushed
the
raft
branch
5 times, most recently
from
baba32f
to
9c639ff
Compare
Licenser
force-pushed
the
raft
branch
3 times, most recently
from
f55341b
to
57c2f86
Compare
Licenser
force-pushed
the
raft
branch
3 times, most recently
from
9b82ae4
to
123cf97
Compare
Licenser
force-pushed
the
raft
branch
5 times, most recently
from
0832376
to
caa48e2
Compare
Licenser
force-pushed
the
raft
branch
7 times, most recently
from
8e8a84f
to
b478ae1
Compare
darach
reviewed
Nov 8, 2023
darach
reviewed
Nov 8, 2023
darach
reviewed
Nov 8, 2023
Licenser
force-pushed
the
raft
branch
6 times, most recently
from
c5f3cdb
to
c230bb6
Compare
Signed-off-by: Heinz N. Gies <[email protected]> Signed-off-by: Matthias Wahl <[email protected]> Move startup and stop logic into ClusterNode and RunningClusterNode It looked cleaner from my angle and now we can properly stop the machinery and all its tasks. Unify cluster start and join to one command: cluster start --join ... Signed-off-by: Matthias Wahl <[email protected]> Update to openraft higher-cote branch rebased on openraft main Signed-off-by: Matthias Wahl <[email protected]> Do not connect in TremorNetwork::new_client this call is not guarded by a timeout, so if we cannot connect we are going to hang in the TCP connect call. Signed-off-by: Matthias Wahl <[email protected]> improve docs for tremor_common::file::is_empty Signed-off-by: Matthias Wahl <[email protected]> Redesign flow task and state machine. deploying a flow does not automatically start it. That needs to be done explicitly in a second step. Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]> Add remove_node operation to the API client Signed-off-by: Matthias Wahl <[email protected]> k8s autoscaling experiment Signed-off-by: Heinz N. Gies <[email protected]> Fail the client if it returns a non-200, so it doesn't try to deserialize an error struct as a regular response Signed-off-by: Matthias Wahl <[email protected]> Refactor our custom raft statemachines into seperate sub-statemachines Signed-off-by: Matthias Wahl <[email protected]> Make sure the network impl reconnects upon errors Signed-off-by: Matthias Wahl <[email protected]> Add some more cluster tests Signed-off-by: Matthias Wahl <[email protected]> Add app id and flow id to common ids and logs Signed-off-by: Matthias Wahl <[email protected]> Update HTTP server library and API Signed-off-by: Heinz N. Gies <[email protected]> Change config to defaults and improve errors Signed-off-by: Heinz N. Gies <[email protected]> Allow connectors access to raft api Signed-off-by: Heinz N. Gies <[email protected]> Remove old API Signed-off-by: Heinz N. Gies <[email protected]> Add clustered kv and API improvements Signed-off-by: Heinz N. Gies <[email protected]> Add cluster::node_id tremorscript function Signed-off-by: Heinz N. Gies <[email protected]> Improve networking and cleanup * Add two examples * Update tremor new to create clustered apps * Fix memory corruption when apps are uninstalled * Try optimizing storage and n2n coms Signed-off-by: Heinz N. Gies <[email protected]> Remove unused deps Signed-off-by: Heinz N. Gies <[email protected]> Remove unused LINE_REGEXP lazy_static in tremor-pipeline to fix build Signed-off-by: Darach Ennis <[email protected]> Fix non consistant reads Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
|
We should eventually discuss how to deal with this PR, the connector separation did force a quite different architecture to raft so there are a lot of conflicting parts in this PR It will at least need a rearchitrecting of how the raft subsystem interacts with connectors - which is probably a significant change the simplest solution might be to completely kill the idea of a raft based connector or at least the only idea I have right now without leaking raft into every connector which seems icky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Clustering
Related
Checklist
Performance