Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.70.0 update #2330

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Rust 1.70.0 update #2330

merged 2 commits into from
Jun 20, 2023

Conversation

Licenser
Copy link
Member

Pull request

Description

rust update

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

-/-

Signed-off-by: Heinz N. Gies <[email protected]>
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #2330 (dcb699a) into main (bb73b23) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head dcb699a differs from pull request most recent head b5dddb2. Consider uploading reports for the commit b5dddb2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
- Coverage   91.07%   91.01%   -0.07%     
==========================================
  Files         275      275              
  Lines       58189    58211      +22     
==========================================
- Hits        52997    52982      -15     
- Misses       5192     5229      +37     
Flag Coverage Δ
unittests 91.01% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors/impls/udp/server.rs 85.36% <ø> (ø)
tremor-pipeline/src/op/trickle/select/test.rs 98.70% <ø> (ø)
tremor-script/src/ast.rs 93.25% <ø> (ø)

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb73b23...b5dddb2. Read the comment docs.

ramonacat
ramonacat previously approved these changes Jun 17, 2023
Signed-off-by: Heinz N. Gies <[email protected]>
Copy link
Member

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

@Licenser Licenser merged commit b139a8e into main Jun 20, 2023
@Licenser Licenser deleted the rust-1.70.0 branch June 20, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants