Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simd-json and halfbrown #2336

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Update simd-json and halfbrown #2336

merged 1 commit into from
Jun 26, 2023

Conversation

Licenser
Copy link
Member

Pull request

Description

Update to simd-json 0.10 with some new features and improved known key code :D

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

-/-

darach
darach previously approved these changes Jun 26, 2023
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Heinz N. Gies <[email protected]>
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #2336 (1057f5a) into main (35b0f69) will increase coverage by 0.02%.
The diff coverage is 97.38%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2336      +/-   ##
==========================================
+ Coverage   91.01%   91.03%   +0.02%     
==========================================
  Files         275      275              
  Lines       58220    58235      +15     
==========================================
+ Hits        52989    53015      +26     
+ Misses       5231     5220      -11     
Flag Coverage Δ
unittests 91.03% <97.38%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors/impls/elastic.rs 94.37% <ø> (ø)
tremor-pipeline/src/op/trickle/operator.rs 88.52% <0.00%> (+5.44%) ⬆️
tremor-value/src/macros.rs 100.00% <ø> (ø)
src/connectors/sink/channel_sink.rs 85.05% <66.66%> (-0.05%) ⬇️
src/codec/tremor.rs 89.79% <80.00%> (-0.24%) ⬇️
tremor-pipeline/src/metrics.rs 72.88% <83.33%> (ø)
tremor-value/src/serde/value/se.rs 76.53% <85.71%> (ø)
src/codec/binflux.rs 79.08% <100.00%> (ø)
src/codec/dogstatsd.rs 95.88% <100.00%> (ø)
src/codec/statsd.rs 92.69% <100.00%> (ø)
... and 25 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b0f69...1057f5a. Read the comment docs.

Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darach darach merged commit b733b1d into main Jun 26, 2023
18 checks passed
@darach darach deleted the simd-json-0.10 branch June 26, 2023 12:37
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants