Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in GBQ batching #2342

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Fix bug in GBQ batching #2342

merged 1 commit into from
Aug 15, 2023

Conversation

Licenser
Copy link
Member

Pull request

Description

When using batches with GBQ where the data wasn't stored.

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

-/-

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #2342 (19afe0a) into main (bfe12a7) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2342      +/-   ##
==========================================
+ Coverage   90.96%   91.02%   +0.05%     
==========================================
  Files         275      275              
  Lines       58649    58652       +3     
==========================================
+ Hits        53350    53386      +36     
+ Misses       5299     5266      -33     
Flag Coverage Δ
unittests 91.02% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/connectors/impls/gbq/writer/sink.rs 96.13% <100.00%> (-0.08%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe12a7...19afe0a. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Heinz N. Gies <[email protected]>
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Licenser Licenser merged commit 6355664 into main Aug 15, 2023
18 checks passed
@Licenser Licenser deleted the gbq-batch-fix branch August 15, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants