fix(connect): skip tests for unsupported coins on new devices #13901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martykan
requested review from
mroz22,
szymonlesisz and
Nodonisko
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found this while working on #13865, decided it would probably be a better idea to make a separate PR for this.
The nightly Connect tests currently run even for coins that are no longer supported on the Safe series - specifically NEM, EOS, Bgold, Dash, Decred
This PR skips the NEM, EOS suites altogether for these models.
Since the other coins are Bitcoin-based, I added a new rule format to the legacyTest rules, which can be used to exclude device models - eg.
'!T2B1'