-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Tor daemon from Tor browser experimental #16091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karliatto
force-pushed
the
feat/tor-external-various-ports
branch
from
December 27, 2024 13:28
d5cea60
to
62dd11e
Compare
karliatto
added
the
build-desktop
This will trigger the build of desktop apps for your PR
label
Dec 27, 2024
karliatto
commented
Dec 27, 2024
karliatto
requested review from
MiroslavProchazka,
szymonlesisz and
marekrjpolak
as code owners
December 27, 2024 13:29
karliatto
changed the title
wip: use Tor daemon from Tor browser experimental
Use Tor daemon from Tor browser experimental
Dec 27, 2024
karliatto
force-pushed
the
feat/tor-external-various-ports
branch
from
December 30, 2024 14:11
62dd11e
to
b3aa1f8
Compare
karliatto
added
build-desktop
This will trigger the build of desktop apps for your PR
and removed
build-desktop
This will trigger the build of desktop apps for your PR
labels
Dec 30, 2024
marekrjpolak
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and seems to be working. I was briefly able to use nonexistent external Tor on port 9150 (it silently used bundled one instead), but then I wiped storage and wasn't able to reproduce again, so I believe it was just a glitch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow user to configure Tor External Port to use "Custom Tor (9050)" or "Tor Browser (9150)
The main idea of this is to make the usage of external Tor daemon easier. In case use wants to use Tor daemon from Tor Browser with some Tor bridge they can. So they do not have do it themselves and they can for example configure snowflake in Tor Browser and use it in Trezor Suite.
We can change the UI how it is presented to the user. And we need to update documentation, but this makes it all quite easier for user.
🤔
I am thinking if adding new option to the select (Tor bundled) will make it better, like:
I haven't done it like that since Tor Bundled is used when Tor external is disabled.
Screenshots: