Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tor daemon from Tor browser experimental #16091

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

karliatto
Copy link
Member

@karliatto karliatto commented Dec 20, 2024

Description

Allow user to configure Tor External Port to use "Custom Tor (9050)" or "Tor Browser (9150)
The main idea of this is to make the usage of external Tor daemon easier. In case use wants to use Tor daemon from Tor Browser with some Tor bridge they can. So they do not have do it themselves and they can for example configure snowflake in Tor Browser and use it in Trezor Suite.

We can change the UI how it is presented to the user. And we need to update documentation, but this makes it all quite easier for user.

🤔
I am thinking if adding new option to the select (Tor bundled) will make it better, like:

  • Tor bundled
  • Tor external custom (9050)
  • Tor from Tor browser (9150)

I haven't done it like that since Tor Bundled is used when Tor external is disabled.

Screenshots:

image

@karliatto karliatto force-pushed the feat/tor-external-various-ports branch from d5cea60 to 62dd11e Compare December 27, 2024 13:28
@karliatto karliatto added the build-desktop This will trigger the build of desktop apps for your PR label Dec 27, 2024
@karliatto karliatto marked this pull request as ready for review December 27, 2024 13:29
@karliatto karliatto changed the title wip: use Tor daemon from Tor browser experimental Use Tor daemon from Tor browser experimental Dec 27, 2024
@karliatto karliatto requested a review from mroz22 December 27, 2024 13:29
@karliatto karliatto added this to the Connect Explorer milestone Dec 30, 2024
@karliatto karliatto force-pushed the feat/tor-external-various-ports branch from 62dd11e to b3aa1f8 Compare December 30, 2024 14:11
@karliatto karliatto added build-desktop This will trigger the build of desktop apps for your PR and removed build-desktop This will trigger the build of desktop apps for your PR labels Dec 30, 2024
Copy link
Contributor

@marekrjpolak marekrjpolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seems to be working. I was briefly able to use nonexistent external Tor on port 9150 (it silently used bundled one instead), but then I wiped storage and wasn't able to reproduce again, so I believe it was just a glitch.

@karliatto karliatto merged commit 31c287b into develop Jan 6, 2025
29 of 33 checks passed
@karliatto karliatto deleted the feat/tor-external-various-ports branch January 6, 2025 12:32
@bosomt
Copy link
Contributor

bosomt commented Jan 8, 2025

QA OK

image image

Info:

  • Suite version: desktop 0.25.1 (4403882efb2a4a802c3d77917d6350a4fae7663d)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/0.25.1 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3B1 2.8.7 regular (revision f2aeea159f1fde98d4fc5575350a8c9fc4478367)
  • Transport: BridgeTransport 3.0.0-bundled.0.25.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-desktop This will trigger the build of desktop apps for your PR
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

3 participants