fix(suite-native): show spinner for pending transactions in lists #16105
+13
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
yanascz
force-pushed
the
fix/native/pending-transaction-spinner
branch
from
9b75a9c to
dc02ffb
Compare
PeKne
approved these changes
Jan 2, 2025
| @@ -155,7 +150,9 @@ export const TransactionListItemContainer = ({ | |||
| contractAddress={contractAddress} | |||
| transactionType={transactionType} | |||
| isAnimated={isTransactionPending} | |||
| iconColor={iconColor} | |||
| iconColor="iconDefault" | |||
| spinnerColor="backgroundAlertYellowBold" | |||
There was a problem hiding this comment.
what about setting these values of spinnerColor and spinnerWidth as default in the TransactionIcon component? So if you pass isAnimated=true then there will be animation displayed by default? It would make sense to me. Up to you.
There was a problem hiding this comment.
I thought about it too but decided not to do that. However, you motivated me to be even more radical. 😅
yanascz
force-pushed
the
fix/native/pending-transaction-spinner
branch
from
6d363ec to
858553f
Compare
yanascz
commented
Jan 4, 2025
| @@ -125,7 +125,6 @@ export const TransactionNotification = ({ | |||
| transactionType={transactionType} | |||
| symbol={notification.symbol} | |||
| isAnimated={isIconAnimated} | |||
| iconColor={isIconAnimated ? 'iconAlertYellow' : 'iconSubdued'} | |||
There was a problem hiding this comment.
@shenkys explicitly asked for the icon to use the default colour no matter what. I missed this in the initial commit.
yanascz
force-pushed
the
fix/native/pending-transaction-spinner
branch
from
858553f to
2ef927b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots: