-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/update wasabi binaries #6967
Conversation
c68bea3
to
e304efe
Compare
@@ -10,8 +10,10 @@ BINARY_NAME=WalletWasabi.WabiSabiClientLibrary | |||
7z x -y CoinjoinClientLibrary-binary.zip | |||
|
|||
# Re-naming direcotry from osx to mac to match the naming using in all the processes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
direcotry 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.
I liked it more when getPort returned something and startOnPart accepted something. Feels more readable to me rather than having side effects. Probably just personal preference.
not sure what side effects you are talking about, but i needed to assing i was even thinking to rename it to |
Mac binaries are not signed, right? @vdovhanych Could you please sign them? 🙏 |
e304efe
to
0f922bd
Compare
maybe we should sign them at build then? |
from commit: trezor/coinjoin-backend@e7ea05c changes: - added /get-version endpoint - fixed memory leak in /select-utxo-for-round - fixed memory leak in /analyze-transaction
0f922bd
to
f43aabf
Compare
binaries signed for mac |
related issue trezor/coinjoin-backend#15 |
Description
update binaries from commit: trezor/coinjoin-backend@e7ea05c
binary changes:
/get-version
endpoint/select-utxo-for-round
results with timeout/analyze-transaction
fix Repair absurdly highanonymity level
#6950 and fix Missing anonymity level in transaction detail #6938suite changes:
/get-version
in CoinjoinProcess.statusgetPort
method of CoinjoinProcessgetUrl
method of CoinjoinProcess