Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update wasabi binaries #6967

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Conversation

szymonlesisz
Copy link
Contributor

@szymonlesisz szymonlesisz commented Nov 21, 2022

Description

update binaries from commit: trezor/coinjoin-backend@e7ea05c

binary changes:

suite changes:

  • use and log /get-version in CoinjoinProcess.status
  • create and use getPort method of CoinjoinProcess
  • create and use getUrl method of CoinjoinProcess

@szymonlesisz szymonlesisz added this to the CoinJoin 🥣 milestone Nov 21, 2022
@szymonlesisz szymonlesisz force-pushed the chore/update-wasabi-binaries branch 2 times, most recently from c68bea3 to e304efe Compare November 21, 2022 16:56
@@ -10,8 +10,10 @@ BINARY_NAME=WalletWasabi.WabiSabiClientLibrary
7z x -y CoinjoinClientLibrary-binary.zip

# Re-naming direcotry from osx to mac to match the naming using in all the processes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

direcotry 😭

Copy link
Contributor

@mroz22 mroz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.
I liked it more when getPort returned something and startOnPart accepted something. Feels more readable to me rather than having side effects. Probably just personal preference.

@szymonlesisz
Copy link
Contributor Author

not sure what side effects you are talking about, but i needed to assing CoinjoinProcess.port before CoinjoinProcess.startOnPort is called to generate valid url, therefore assigning port again CoinjoinProcess.startOnPort doesnt make sesne anymore.

i was even thinking to rename it to CoinjoinProcess.start but didnt do it

@matejkriz
Copy link
Member

Mac binaries are not signed, right? @vdovhanych Could you please sign them? 🙏

@szymonlesisz
Copy link
Contributor Author

maybe we should sign them at build then?

from commit: trezor/coinjoin-backend@e7ea05c

changes:
- added /get-version endpoint
- fixed memory leak in /select-utxo-for-round
- fixed memory leak in /analyze-transaction
@vdovhanych
Copy link
Member

binaries signed for mac

@matejkriz
Copy link
Member

maybe we should sign them at build then?

related issue trezor/coinjoin-backend#15

@szymonlesisz szymonlesisz merged commit 5fc2402 into develop Nov 22, 2022
@szymonlesisz szymonlesisz deleted the chore/update-wasabi-binaries branch November 22, 2022 16:19
@tsusanka tsusanka added the coinjoin Related to coinjoin feature label Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coinjoin Related to coinjoin feature Roadmap: Product
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Repair absurdly high anonymity level Missing anonymity level in transaction detail
5 participants