Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: sign transaction #28

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

spalmer25
Copy link
Collaborator

This MR adds a tests to check that signing transaction is not allowed.

@spalmer25 spalmer25 added the tests label Feb 5, 2024
@spalmer25 spalmer25 added this to the DAL-Support milestone Feb 5, 2024
@spalmer25 spalmer25 self-assigned this Feb 5, 2024
@spalmer25 spalmer25 force-pushed the palmer@functori@test-sign-transaction branch from 88555c5 to e6b9993 Compare February 5, 2024 15:58
@spalmer25 spalmer25 changed the base branch from main to palmer@functori@test-delegation-signing February 5, 2024 15:58
@spalmer25 spalmer25 linked an issue Feb 5, 2024 that may be closed by this pull request
Copy link
Collaborator Author

@spalmer25 spalmer25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge while MR target is not main

@spalmer25 spalmer25 marked this pull request as ready for review February 5, 2024 16:04
@spalmer25 spalmer25 force-pushed the palmer@functori@test-delegation-signing branch 2 times, most recently from 25cdc8d to e53f65e Compare February 6, 2024 08:04
@spalmer25 spalmer25 force-pushed the palmer@functori@test-sign-transaction branch from e6b9993 to d336881 Compare February 6, 2024 08:06
@spalmer25 spalmer25 changed the base branch from palmer@functori@test-delegation-signing to main February 6, 2024 09:18
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinkyaraj-23 ajinkyaraj-23 merged commit c1b1cbf into main Feb 6, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests: add test that ensure that no transaction can be signed
2 participants