Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed base58 file as its duplicate wrt base58 in SDK #41

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

ajinkyaraj-23
Copy link
Collaborator

No description provided.

@ajinkyaraj-23 ajinkyaraj-23 added this to the Baking app upgrade milestone Feb 23, 2024
@ajinkyaraj-23 ajinkyaraj-23 self-assigned this Feb 23, 2024
@ajinkyaraj-23 ajinkyaraj-23 linked an issue Feb 23, 2024 that may be closed by this pull request
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 32-duplicate-files-with-ledger-secure-sdk branch from 42e97bc to f1a4e30 Compare February 23, 2024 09:36
Copy link
Collaborator

@spalmer25 spalmer25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use the base58 from SDK instead of our hand-made base58 ?

@ajinkyaraj-23
Copy link
Collaborator Author

Is it possible to use the base58 from SDK instead of our hand-made base58 ?

Let me check.

@ajinkyaraj-23
Copy link
Collaborator Author

Is it possible to use the base58 from SDK instead of our hand-made base58 ?

This solves the specific problem of duplicate files. Lets merge this now. I will create another issue for using base58 form SDK. I need to figure out the include path as using SDK base58 gives compilation error saying file not found.

@spalmer25 spalmer25 merged commit c866189 into main Feb 23, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate files with ledger-secure-sdk
2 participants