Stax: review operation splash screen must wait for tap to advance #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
emturner
commented
Oct 30, 2023
•
emturner
commented
- Fixes Stax: 'review request to sign' splash screen must only advance with finger press #89
- realised this same issue kind of also applies to the parsing error screens, which were shown immediately, rather than waiting for the user to reach them
emturner
added
bug
emturner
force-pushed
the
emturner@review-wait-for-tap
branch
from
ddd0c27 to
a349a44
Compare
emturner
force-pushed
the
emturner@review-wait-for-tap
branch
from
a349a44 to
764689a
Compare
emturner
changed the title
spalmer25
reviewed
Oct 31, 2023
emturner
force-pushed
the
emturner@review-wait-for-tap
branch
from
764689a to
9133501
Compare
spalmer25
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.