tests: temporarily fix flaky pk tests #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emturner
force-pushed
the
emturner@pk-flake
branch
from
04aaecf to
19bf477
Compare
Due to flakiness around `send_apdu`/`expect_apdu_return`
emturner
force-pushed
the
emturner@pk-flake
branch
from
19bf477 to
d92d27f
Compare
emturner
changed the title
spalmer25
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ultimately due to assuming
send_apduis synchronous, when in fact it runs in the background. This can lead toexpect_apdu_returndoing its check before the apdu call is complete, unless intermediate steps are in place