Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style guide #232

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Style guide #232

merged 7 commits into from
Jan 24, 2024

Conversation

timothymcmackin
Copy link
Collaborator

@timothymcmackin timothymcmackin commented Dec 29, 2023

Style guide for Tezos docs based on things I've observed. Very open to suggestions here.

This guide does not take a stance on US English vs. British English. en_US is more popular but en_GB would be fine because TriliTech is a British-based company.

Preview: https://docs-staging-git-style-guide-trili-tech.vercel.app/reference/style-guide

@timothymcmackin timothymcmackin self-assigned this Dec 29, 2023
Copy link

vercel bot commented Dec 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-staging ✅ Ready (Inspect) Visit Preview Jan 15, 2024 6:33pm

@timothymcmackin timothymcmackin marked this pull request as ready for review January 3, 2024 19:12
@timothymcmackin timothymcmackin requested a review from a team as a code owner January 3, 2024 19:12
Copy link
Collaborator

@NicNomadic NicNomadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with all the items but a few, and have also a few questions.

docs/reference/style-guide.md Show resolved Hide resolved
docs/reference/style-guide.md Show resolved Hide resolved
docs/reference/style-guide.md Outdated Show resolved Hide resolved

- Do not use "once" to mean "after," as in "Once the system shuts down, you can safely remove the drive."

- Avoid Latinate abbreviations like e.g. and i.e.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's clearer writing style to not use such abbreviations. "For example" is clearer than "e.g." and "i.e." usually doesn't provide a clear connection between two thoughts.

docs/reference/style-guide.md Outdated Show resolved Hide resolved
docs/reference/style-guide.md Outdated Show resolved Hide resolved
@NicNomadic
Copy link
Collaborator

NicNomadic commented Jan 15, 2024

We could enrich this guide with pragmatic rules, such as: in the beginning of each tutorial, clearly mention what versions are used for each tool involved. This ensures more robustness in time. Or maybe this is not a style issue?

Copy link
Contributor

@beatalipska beatalipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very needed, very good! 👏🏻

Copy link
Collaborator

@NicNomadic NicNomadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@timothymcmackin
Copy link
Collaborator Author

We could enrich this guide with pragmatic rules, such as: in the beginning of each tutorial, clearly mention what versions are used for each tool involved. This ensures more robustness in time. Or maybe this is not a style issue?

Yes, that could be good follow-up: standards for tutorials, diagrams, code samples, descriptions of tools and programs, and page structure.

@timothymcmackin timothymcmackin merged commit c2ffabd into staging Jan 24, 2024
4 checks passed
@timothymcmackin timothymcmackin deleted the style-guide branch January 24, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants