Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit security tutorial for review #258

Merged
merged 11 commits into from
Jan 31, 2024
Merged

Conversation

zamrokk
Copy link
Contributor

@zamrokk zamrokk commented Jan 11, 2024

Please give me any feedback on the security tutorial.
If more code is required to understand or hack a specific thing, please tell me.
It is not often easy to test security threats

@zamrokk zamrokk requested a review from a team as a code owner January 11, 2024 15:19
Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-staging ✅ Ready (Inspect) Visit Preview Jan 30, 2024 2:42pm

@zamrokk
Copy link
Contributor Author

zamrokk commented Jan 22, 2024

Grammar is fixed. Is it ok now ?

@timothymcmackin
Copy link
Collaborator

I rebased and added some fixes to get this to build.

Copy link
Collaborator

@timothymcmackin timothymcmackin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review well because the repos appear to be missing or private.

.vscode/settings.json Show resolved Hide resolved
docs/tutorials/security.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-1.md Show resolved Hide resolved
docs/tutorials/security/part-1.md Outdated Show resolved Hide resolved
docs/tutorials/security.md Outdated Show resolved Hide resolved
docs/tutorials/security.md Show resolved Hide resolved
docs/tutorials/security/part-1.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-1.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-1.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-3.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-3.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-3.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-3.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-3.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@timothymcmackin timothymcmackin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overview page has a long section on off-chain security, but the active parts of the tutorial are all on-chain security. Maybe this overview, both the on-chain and off-chain part, should be moved to a Security page under https://docs.tezos.com/dApps/best-practices?

docs/tutorials/security/part-1.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-1.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-1.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-1.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-1.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-1.md Outdated Show resolved Hide resolved
docs/tutorials/security/part-1.md Show resolved Hide resolved
docs/tutorials/security/part-2.md Show resolved Hide resolved
docs/tutorials/security/part-2.md Outdated Show resolved Hide resolved
@zamrokk
Copy link
Contributor Author

zamrokk commented Jan 31, 2024

The overview page has a long section on off-chain security, but the active parts of the tutorial are all on-chain security. Maybe this overview, both the on-chain and off-chain part, should be moved to a Security page under https://docs.tezos.com/dApps/best-practices?

Lot of offchain hacks are very basic web2 hacks. IMO, it is not necessary to invest too much on this as it does not add something new.
Onchain attacks are specific to web3 and new. It is important to explain how to protect against it

About the location of the introduction. Up to you. It is not just about "best practice", it is about security concern

@timothymcmackin
Copy link
Collaborator

The overview page has a long section on off-chain security, but the active parts of the tutorial are all on-chain security. Maybe this overview, both the on-chain and off-chain part, should be moved to a Security page under https://docs.tezos.com/dApps/best-practices?

Lot of offchain hacks are very basic web2 hacks. IMO, it is not necessary to invest too much on this as it does not add something new. Onchain attacks are specific to web3 and new. It is important to explain how to protect against it

About the location of the introduction. Up to you. It is not just about "best practice", it is about security concern

All right, I'm OK with it as it is. Should I merge it with my and Claude's approval?

@zamrokk
Copy link
Contributor Author

zamrokk commented Jan 31, 2024

The overview page has a long section on off-chain security, but the active parts of the tutorial are all on-chain security. Maybe this overview, both the on-chain and off-chain part, should be moved to a Security page under https://docs.tezos.com/dApps/best-practices?

Lot of offchain hacks are very basic web2 hacks. IMO, it is not necessary to invest too much on this as it does not add something new. Onchain attacks are specific to web3 and new. It is important to explain how to protect against it
About the location of the introduction. Up to you. It is not just about "best practice", it is about security concern

All right, I'm OK with it as it is. Should I merge it with my and Claude's approval?

For me it is ok, it can be improved later with future feedbacks

@timothymcmackin
Copy link
Collaborator

Merging. Thanks, @zamrokk!

@timothymcmackin timothymcmackin merged commit 901ddc0 into staging Jan 31, 2024
4 checks passed
@timothymcmackin timothymcmackin deleted the security-tutorial branch January 31, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants