-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commit security tutorial for review #258
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Grammar is fixed. Is it ok now ? |
I rebased and added some fixes to get this to build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't review well because the repos appear to be missing or private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overview page has a long section on off-chain security, but the active parts of the tutorial are all on-chain security. Maybe this overview, both the on-chain and off-chain part, should be moved to a Security page under https://docs.tezos.com/dApps/best-practices?
Lot of offchain hacks are very basic web2 hacks. IMO, it is not necessary to invest too much on this as it does not add something new. About the location of the introduction. Up to you. It is not just about "best practice", it is about security concern |
All right, I'm OK with it as it is. Should I merge it with my and Claude's approval? |
For me it is ok, it can be improved later with future feedbacks |
Merging. Thanks, @zamrokk! |
Please give me any feedback on the security tutorial.
If more code is required to understand or hack a specific thing, please tell me.
It is not often easy to test security threats