add comments for health check test

trinodb · Sep 24, 2023 · 56b5f7e · 56b5f7e
1 parent 5cb18a5
commit 56b5f7e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/localdev/docker-compose.yml b/localdev/docker-compose.yml
@@ -9,6 +9,7 @@ services:
     ports:
       - "3306:3306"
     healthcheck:
+      # Need root password to check MySQL server status
       test: ["CMD", "mysqladmin", "ping", "-h", "localhost", "-proot123"]
       start_period: 20s
       timeout: 5s
@@ -27,13 +28,12 @@ services:
       - PGPORT=5432
       - POSTGRES_PASSWORD=P0stG&es
       - POSTGRES_DB=trino_gateway_db
-      - PGDATABASE=trino_gateway_db
       - POSTGRES_USER=trino_gateway_db_admin
-      - PGUSER=trino_gateway_db_admin
     ports:
       - "5432:5432"
     healthcheck:
-      test: ["CMD-SHELL", "pg_isready || exit 1"]
+      # Need user and database name to check PostgreSQL server status
+      test: ["CMD-SHELL", "pg_isready -U $$POSTGRES_USER -d $$POSTGRES_DB || exit 1"]
       interval: 10s
       timeout: 3s
       retries: 3