Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve project setup #29

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Improve project setup #29

merged 1 commit into from
Sep 20, 2023

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Sep 6, 2023 •
edited
Loading

  • Add airbase as parent to enable release in future
  • Add necessary details for release
  • Add airbase property overrides to skip various checks to allow passing build
  • Move test code into correct path
  • Centralize property declarations in parent pom
  • Improve dependency declarations and add version overrides as minimally needed

Fixes #3
Fixes #14

@cla-bot cla-bot bot added the cla-signed label Sep 6, 2023
This was referenced Sep 6, 2023
Closed
Closed
@mosabua
Copy link
Member Author

mosabua commented Sep 7, 2023

Currently there are test failures related to some classpath issues .. @willmostly and myself are looking but if anybody else wants to chime in that would help

@mosabua mosabua force-pushed the airbase branch 6 times, most recently from 19a1bac to 06f328b Compare September 11, 2023 23:00
@mosabua mosabua changed the title WIP - Improve project setup Improve project setup Sep 11, 2023
dain
dain reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@dain dain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor formatting issues

baseapp/pom.xml Outdated Show resolved Hide resolved
baseapp/pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
mosabua
mosabua commented Sep 11, 2023
View reviewed changes
pom.xml
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Copy link
Member Author

@mosabua mosabua Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removed because we want to move to the Trino/Airlift style and validation anyway

willmostly
willmostly approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@willmostly willmostly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, otherwise LGTM

pom.xml Outdated Show resolved Hide resolved
@mosabua mosabua force-pushed the airbase branch 2 times, most recently from df4c3f5 to 185d651 Compare September 18, 2023 16:35
@wendigo
Copy link
Contributor

wendigo commented Sep 18, 2023

@mosabua can you split this PR into multiple commits?

wendigo
wendigo reviewed Sep 18, 2023
View reviewed changes
pom.xml Show resolved Hide resolved
wendigo
wendigo reviewed Sep 18, 2023
View reviewed changes
pom.xml Show resolved Hide resolved
wendigo
wendigo reviewed Sep 18, 2023
View reviewed changes
pom.xml Show resolved Hide resolved
wendigo
wendigo reviewed Sep 18, 2023
View reviewed changes
pom.xml Show resolved Hide resolved
wendigo
wendigo reviewed Sep 18, 2023
View reviewed changes
pom.xml Show resolved Hide resolved
@mosabua
Copy link
Member Author

mosabua commented Sep 18, 2023

@mosabua can you split this PR into multiple commits?

Not really .. this current setup is necessary for it to build. If I split it up the commits in between wont build.

@andythsu
Copy link
Member

I have a script running some tasks against the gateway with changes in this PR and it seems to be running fine. It's good for me.

@mosabua
Copy link
Member Author

mosabua commented Sep 20, 2023 •
edited
Loading

Rebased #17 from main into here now .. everything still working.

vishalya
vishalya approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@vishalya vishalya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in a decent shape now. I am able to compile and test locally.

@mosabua
Improve project setup
d39c4d8 
- Add airbase as parent to enable release in future
- Add necessary details for release
- Add airbase property overrides to skip various checks to allow passing build
- Centralize property declarations in parent pom
- Improve dependency declarations and add version overrides as minimally needed
- Improve groupid naming
@mosabua mosabua mentioned this pull request Sep 20, 2023
Merged
@mosabua mosabua merged commit 55bff33 into trinodb:main Sep 20, 2023
2 checks passed
@mosabua mosabua deleted the airbase branch September 20, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendigo wendigo wendigo left review comments

@dain dain dain approved these changes

@nineinchnick nineinchnick nineinchnick approved these changes

@vishalya vishalya vishalya approved these changes

@willmostly willmostly willmostly approved these changes

@andythsu andythsu andythsu approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add airbase as parent Add release process tooling
7 participants
@mosabua @wendigo @andythsu @dain @nineinchnick @vishalya @willmostly