Use regex expression for authorization #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmostly
reviewed
Sep 15, 2023
willmostly
reviewed
Sep 18, 2023
Chaho12
force-pushed
the
feature/jaeho.yoo/allow_regex_authorization
branch
2 times, most recently
from
2172b7d
to
d4d5de7
Compare
Chaho12
force-pushed
the
feature/jaeho.yoo/allow_regex_authorization
branch
from
d4d5de7
to
68e922b
Compare
|
Rebased and pushed to be ready for merge |
mosabua
approved these changes
Oct 5, 2023
willmostly
reviewed
Oct 6, 2023
gateway-ha/src/test/java/io/trino/gateway/ha/security/TestLbAuthorizer.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/security/TestLbAuthorizer.java
Outdated
Show resolved
Hide resolved
|
Sorry for the delay @Chaho12 - I had a review pending that I didn't realize never got submitted |
|
Could you rebase and adjust to review comments please @Chaho12 ? Or maybe wait until the test refactor to use junit is in .. and then adapt. |
Chaho12
force-pushed
the
feature/jaeho.yoo/allow_regex_authorization
branch
2 times, most recently
from
ced88bb
to
8a9da6d
Compare
Chaho12
force-pushed
the
feature/jaeho.yoo/allow_regex_authorization
branch
from
8a9da6d
to
e772a0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use regex instead of contains to support more cases where more than 1 type of user members can exist and not all but some of the groups/members are allowed for User role.