Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update server command in development doc #33

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Update server command in development doc #33

merged 1 commit into from
Sep 12, 2023

Conversation

Chaho12
Copy link
Member

@Chaho12 Chaho12 commented Sep 12, 2023

Mistakenly close branch

Waiting for #25 branch to be merged

@cla-bot cla-bot bot added the cla-signed label Sep 12, 2023
mosabua
mosabua approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already are at 17 .. this is necessary and should be added. #25 can be adjusted independently.

@mosabua
Copy link
Member

mosabua commented Sep 12, 2023

Fyi @willmostly I am merging this. You might have to rebase while you fix #25

@mosabua mosabua merged commit ca1ed85 into trinodb:main Sep 12, 2023
2 checks passed
@Chaho12 Chaho12 deleted the feauture/jaeho.yoo/update_development_cmd branch September 13, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosabua mosabua mosabua approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chaho12 @mosabua