Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring multiple access-control.properties in config.properties does not take effect #20152

Open
A-little-bit-of-data opened this issue Dec 18, 2023 · 7 comments

Comments

@A-little-bit-of-data
Copy link

A-little-bit-of-data commented Dec 18, 2023

According to the document description, multiple files were configured, as shown in the figure below. After restarting the coordinator, it was found that it did not take effect through the trino-cli connection, but it was shown in the log that it took effect.
image
image
image
image

But if you write only one property in the access-control.config-files in the config.properties file, and verify that the configuration takes effect through trino-cli query, has anyone encountered this situation? Or is there something wrong with my configuration?

Tasks

Preview Give feedback
No tasks being tracked yet.
@hirolee88
Copy link
Contributor

What UI are you using?
The issue is, there's Trino-admin on the left side, but results not, right?

What is the content of test.json?

@A-little-bit-of-data
Copy link
Author

What UI are you using? The issue is, there's Trino-admin on the left side, but results not, right?

What is the content of test.json?

ui is superset, and Trino-admin represents the user who uses admin. The results on the right should see all catalogs, but only one system is seen. The content of test.json is as follows:

{
"catalogs": [
{
"user": "tpcds",
"catalog": "tpcds",
"allow": "all"
}
],
"schemas": [
{
"user": "tpcds",
"catalog": "tpcds",
"schema": "sf1|sf10",
"owner": false
}
],
"tables": [
{
"catalog": "tpcds",
"schema": "sf1|sf10",
"user": "tpcds",
"table": ".*",
"privileges": [
"SELECT",
"INSERT",
"DELETE",
"UPDATE",
"OWNERSHIP",
"GRANT_SELECT"
]
}
]
}

@A-little-bit-of-data
Copy link
Author

Has anyone encountered this problem before?

@A-little-bit-of-data
Copy link
Author

The problem has been raised for several months. Hasn't the official noticed this problem?

@glebcha
Copy link

glebcha commented Dec 20, 2024

Wonder why such critical issue stay still.
@mosabua , can you help to put this issue in a backlog?

@mosabua
Copy link
Member

mosabua commented Dec 20, 2024

I am pretty sure there is no support for having multiple access control properties of the same type. What made you think that would work .. we might have to update whatever documentation or indication you followed.

@mosabua
Copy link
Member

mosabua commented Dec 20, 2024

Started #24549 to clarify and then close this issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants