Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs for multiple access controls #24549

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Dec 20, 2024

Description

Centralize and clarify usage with multiple access control systems.

Additional context and related issues

See #20152

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@mosabua mosabua requested a review from dain December 20, 2024 18:12
@cla-bot cla-bot bot added the cla-signed label Dec 20, 2024
@github-actions github-actions bot added the docs label Dec 20, 2024
the default `etc/access-control.properties`. Relative paths from the Trino
`INSTALL_PATH` or absolute paths are supported.

The configured access control systems are used in order until access rights are
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this .. also would be good to explain more with an example.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is true, but ordering shouldn't matter. Each access control is independent from the others.

the default `etc/access-control.properties`. Relative paths from the Trino
`INSTALL_PATH` or absolute paths are supported.

The configured access control systems are used in order until access rights are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is true, but ordering shouldn't matter. Each access control is independent from the others.

`INSTALL_PATH` or absolute paths are supported.

The configured access control systems are used in order until access rights are
either granted or denied, and must use different types. Each system is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually "access is granted if none of the access controls denies it" - or: all access controls must allow. But if there are no access controls at all, all access is allowed. That's at the engine level (which is of interest here) and not to be confused with how each individual access control works.

`INSTALL_PATH` or absolute paths are supported.

The configured access control systems are used in order until access rights are
either granted or denied, and must use different types. Each system is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean by "different types"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants