Generate job annotations without GHA REST API #23445
Merged
+17
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a draft, because trinodb/github-actions#34 and starburstdata/action-testng-report#8 are not merged yet. |
|
Tested in https://github.com/nineinchnick/trino/actions/runs/10884950374?pr=18 The annotations now show up in the run summary view even before the run finishes, which is very nice, since we have so many long running jobs. |
nineinchnick
force-pushed
the
annotate-runs
branch
from
bdadf84
to
9bd3233
Compare
nineinchnick
changed the title
nineinchnick
changed the title
wendigo
approved these changes
Sep 17, 2024
|
There's a potentially flaky test failure in sqlserver and we can already see this working as expected: |
|
@nineinchnick nice |
|
@nineinchnick can we upgrade the node versions to reduce the warnings? |
The separate annotate workflow was added to work around permission issues in forked repositories. This is not needed when not using the GHA REST API. Adding annotations via the API was not working correctly anyway, since it added a check for a commit, but one commit can have multiple runs associated with it, and the check sometimes did not show up in the main run.
nineinchnick
force-pushed
the
annotate-runs
branch
from
9bd3233
to
19dc7bb
Compare
wendigo
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The separate annotate workflow was added to work around permission issues in forked repositories. This is not needed when not using the GHA REST API.
Adding annotations via the API was not working correctly anyway, since it added a check for a commit, but one commit can have multiple runs associated with it, and the check sometimes did not show up in the main run.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: