Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running product tests on IPv6 stack #24533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Dec 19, 2024

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Maybe we could enable it for few test suites.

@wendigo
Copy link
Contributor Author

wendigo commented Dec 19, 2024

it's not possible to use IPv6 in GHA: https://github.com/orgs/community/discussions/102779

Comment on lines +310 to +315
format(
"#!/bin/bash\n" +
"ipv6=$(hostname -I | awk '{print $2}')\n" +
"IPv6 address of the node: ${ipv6}\n" +
"echo '-Djava.net.preferIPv6Addresses=true' >> '%s'\n" +
"echo \"node.internal-address=${ipv6}\" >> '%s'\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: text block ? Or can we move them to a dedicated file as well right ? jvm config and etc properties are kind of static.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants