Prevent double close in HTTP client __del__ #467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabrizian
reviewed
Feb 6, 2024
piotrm-nvidia
force-pushed
the
piotrm/prevent_double_close
branch
from
6268ebb to
0f476ad
Compare
|
@jbkyang-nvi / @debermudez let me know if you have any concern with this PR. |
|
Bandwidth is a bit tight at the moment but this seems like an easy include. |
|
Added testing and closed by this ticket: #468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you consider extending del operator to prevent double close() in multi thread environments?
See:
triton-inference-server/server#4223
See:
triton-inference-server/pytriton#63