[Java] Add FP16 Support for Java Client #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
请问java把图片的rgb数组传到推理服务后，服务器需要的格式是uint8格式 java中把获取的r，g，b三个参数转成byt并添加到byte数组后 是有符号的二进制 那需要怎么才能转成无符号的二进制传呢？ |
|
@jbkyang-nvi can you review this code? I think you were the one who mainly worked on the java client. If I'm mistaken, can you recommend someone who is familiar with it? |
|
@krishung5 can you take a look? I can review sometimes next week. |
krishung5
reviewed
Nov 17, 2022
| @@ -269,6 +269,50 @@ public double[] getOutputAsDouble(String output) { | |||
| return (double[])getOutputImpl(out, double.class, ByteBuffer::getDouble); | |||
| } | |||
|
|
|||
| public float[] getOutputFp16AsFloat(String output) { | |||
There was a problem hiding this comment.
Could you add the comments for this function like the other ones just for the consistency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change the minimum retryCnt to 0, retry can sometimes be expensive. If it is not acceptable, I will remove that.