Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: RHEL8 PyTorch Backend #7524

Closed
wants to merge 27 commits into from
Closed

Conversation

fpetrini15
Copy link
Contributor

Goal: Support the PyTorch Backend on RHEL8 systems. Importantly, these changes will disable optional PyTorch optional features such as TRITON_PYTORCH_ENABLE_TORCHTRT and TRITON_ENABLE_NVTX, which are not currently supported for the RHEL8 build.

PyTorch Backend: triton-inference-server/pytorch_backend#137

fpetrini15 and others added 24 commits July 8, 2024 15:39
* Update README and versions for 2.48.0 / 24.07
[24.07] Revert vllm to 0.5.0.post1
Downgrade ompi version to v4.1.5rc2
More general capture of Linux Distros

tritonserver compiling except for --filesystem=gcs and --filesystem=s3

adding sbsa installation for dcgm

updating RUNPATH directory for tritonserver executable

cleanup

removed build_ubuntu and updated build.py
* Merge ORT RHEL changes Into Kyle's RHEL dev
build.py Outdated
Comment on lines 922 to 929
df += """
# Point to python 3.10 which is what triton expects the default to be
ENV PYVER 3.10
ENV PYTHONPATH /opt/python/v
RUN ln -sf /opt/python/cp${PYVER/./}* ${PYTHONPATH}
ENV PYBIN ${PYTHONPATH}/bin
ENV PYTHON_BIN_PATH ${PYBIN}/python${PYVER}
ENV PATH ${PYBIN}:${PATH}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need custom location for python installation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manylinux container we are using as a base has several versions of python installed. By default, it will use Python3.7 which is incompatible with some of the packages we need to install. So here we default the version to 3.10.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we use proper version of Python aligned with all DLFW products instead and expanding existing image?

Copy link
Contributor Author

@fpetrini15 fpetrini15 Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.10 is the properly aligned version for Triton and PyTorch as far as I can tell: https://docs.nvidia.com/deeplearning/frameworks/support-matrix/index.html. Realistically, the best place to fix this would be the origin--the base container. I'm not sure what the rationale is for having it default to 3.7.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fix at that level would prevent us and the Pytorch team from having to do this in the first place.

@fpetrini15 fpetrini15 closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants