Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add mutex lock for state completion check in gRPC streaming to prevent race condition #7617

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

pskiran1
Copy link
Member

@pskiran1 pskiran1 commented Sep 16, 2024

What does the PR do?

This PR aims to fix an occasional error (caused by a race condition) that occurs when making multiple asynchronous requests to the ASR model in decoupled mode:

E0829 13:41:44.609857 147 stream_infer_handler.cc:528] "Should not print this! Decoupled should NOT write via WRITEREADY!"

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 18428769

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@pskiran1 pskiran1 marked this pull request as ready for review September 16, 2024 19:07
@pskiran1 pskiran1 added the PR: fix A bug fix label Sep 16, 2024
Copy link
Contributor

@indrajit96 indrajit96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pskiran1 pskiran1 merged commit 68d4c01 into main Sep 17, 2024
3 checks passed
@pskiran1 pskiran1 deleted the spolisetty_grpc_bug_fix_24.08 branch September 17, 2024 18:07
pskiran1 added a commit that referenced this pull request Sep 17, 2024
pskiran1 added a commit that referenced this pull request Sep 19, 2024
pskiran1 added a commit that referenced this pull request Sep 19, 2024
pskiran1 added a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix A bug fix
Development

Successfully merging this pull request may close these issues.

3 participants