Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fetch_models.sh #7621

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

vd-nv
Copy link
Contributor

@vd-nv vd-nv commented Sep 18, 2024

What does the PR do?

The link to download the onnx model in the script is broken. This PR attempts a fix at that.

Checklist

  • I have read the Contribution guidelines and signed the Contributor License
    Agreement
  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • I ran pre-commit locally (pre-commit install, pre-commit run --all)
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

NA

Where should the reviewer start?

Just one file

Test plan:

  • Run the script to get the model
  • Ran several client tests and the model works

Caveats:

NA

Background

The original link to download the model is dead.
Also another use raised this issue: #7608

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Fix onnx model download link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants