refactor: Refactor string input checks #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabrizian
reviewed
Jul 25, 2024
| std::to_string(element_idx)) | ||
| .c_str())); | ||
| if (err != nullptr) { | ||
| RESPOND_AND_SET_NULL_IF_ERROR(response, err); | ||
| FillStringTensor( |
tanmayv25
reviewed
Jul 26, 2024
Tabrizian
previously approved these changes
Jul 26, 2024
This was referenced Jul 30, 2024
yinggeh
changed the title
tanmayv25
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Move each individual check of string input in model backend repos to the bakend repo.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
backend: triton-inference-server/backend#101
tensorflow_backend: #104
pytorch_backend: triton-inference-server/pytorch_backend#136
onnxruntime_backend: triton-inference-server/onnxruntime_backend#263
python_backend: triton-inference-server/python_backend#370
Test plan:
17021222 and 17057045
Background
Initially just to add missing string input tensor checks to python_backend. Refactored because duplicate code from other model backends were found.