feat: "Ignore Array" and "Item Key Formatting Style" options #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e "Additional Options" accordion. - Added "Ignore Array" and "Force Item Key Lowercase" options to the "Additional Options" accordion. - The "Ignore Array" option allows users to preserve all list-like data during conversion. - Included a tooltip with an explanation of list-like data and the option's behavior. - The "Force Item Key Lowercase" option will make item key lowercase during the conversion process. The "Ignore Array" option in the "Additional Options" accordion allows users to preserve any list-like data during the conversion process. The option is accompanied by a tooltip that provides a brief explanation of list-like data and how the option affects the conversion. The implementation includes a `deepCopy` function, which is a custom recursive function used to create deep copies of objects and arrays. This function ensures ignored arrays data are copied from the main language file.
Allow users to select different item key formatting styles: original, lowercase, or uppercase. This replaces the Force Key Lowercase option, providing users with more choices for item key formatting. The option is still available under the "Additional Options" accordion.
Replace Original Conventions option in item key format options to Default.
Modified the "`handleIgnoreArray`" method to correctly store main language values for each unique key path, preventing array value duplication when the "`ignoreArray`" option is enabled. Before the modification, `handleIgnoreArray` only stored the `key`, not the full key path. This resulted in the same value being used for different keys that shared the same `key` at different paths, such as `foo.bar.item.lore` or `bar.foo.item.lore`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces two new options, "Ignore Array" and "Item Key Formatting Style". These options are added to the "Additional Options" accordion in the user interface.
The motivation behind adding the new options
First, I love this tool; it's time-saving for generating Triton collections. While using this tool, I noticed that dealing with multi-line types of messages is a little bit inconvenient, especially when translating scoreboards, as scoreboards do not work the same way as messages.
Item key formatting, well, this is mainly personal preferences but since the generator output is following the message file's key, when the messages file have like:
Messages.INLOBBY.JOIN_MESSAGEis a little bit inconvenient to read, when me much more prefer consistency wanting all the item key are lowercase. This option added the flexibility for that.I believe that these new options enhance the usability of the tool and offer users more control over the output. By providing these choices, users can customize the conversion process according to their specific needs.
Changes Made
"Ignore Array" option
"Item Key Formatting Style" option