[Proof of Concept] Remove all exceptions from fluid-fluid kernel #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these remaining two
@inbounds
, the resulting device code does not contain any exceptions.However, the WCSPH benchmark is only 2% faster on an Nvidia H100, and these two
@inbounds
are not safe, so there is no reason to do this.This PR is just a reference to evaluate the impact of the remaining exceptions and is not meant to be merged.