Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fully parallel atomic initialization #86

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

efaulhaber
Copy link
Member

Moving away from serial initialization with FullGridCellList. I found that this is actually faster for medium to large problems than the incremental update, and it's also much simpler, so I made it the default and added a separate update mode for incremental update.
grafik
I'll have to investigate this in actual simulations and benchmark GPUs before continuing here.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.57%. Comparing base (fde9a79) to head (532a64f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/nhs_grid.jl 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   88.15%   84.57%   -3.59%     
==========================================
  Files          15       15              
  Lines         498      512      +14     
==========================================
- Hits          439      433       -6     
- Misses         59       79      +20     
Flag Coverage Δ
unit 84.57% <82.35%> (-3.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede
Copy link
Member

sloede commented Dec 4, 2024

Nice speedup!

@efaulhaber efaulhaber self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants