Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2D covariant form using P4estMesh #31

Closed
wants to merge 89 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
7ff4a57
linear advection on the sphere
tristanmontoya Jul 13, 2024
8236b78
formatter
tristanmontoya Jul 13, 2024
fcf6c75
very preliminary implementation of covariant form with p4est
tristanmontoya Jul 16, 2024
2fc2f67
removed untracked
tristanmontoya Jul 16, 2024
2e1c54c
removed allocations, now 100x faster
tristanmontoya Jul 16, 2024
c64a293
add DS_Store to gitignore
tristanmontoya Jul 16, 2024
5374da9
add DS_Store to gitignore
tristanmontoya Jul 16, 2024
f9a4163
made equations actually 2D
tristanmontoya Jul 17, 2024
3abdaa6
integrated upstream changes
tristanmontoya Jul 17, 2024
e6e08aa
analysis callback for covariant form
tristanmontoya Jul 18, 2024
e153f11
cleanup
tristanmontoya Jul 19, 2024
f45378e
separate Andres's spherical shell containers from main Trixi
tristanmontoya Jul 25, 2024
24a3793
Added containers and 2D p4est mesh from my spherical shell implementa…
amrueda Jul 26, 2024
eb768d9
Added element container with PtrArray for performance and modified th…
amrueda Jul 26, 2024
ca44965
format
amrueda Jul 26, 2024
8ec3e9c
Fixed bug in the definition of init_elements and added nelements(). e…
amrueda Jul 26, 2024
7caca96
Merge remote-tracking branch 'origin/arr/spherical_shell' into tm/p4e…
tristanmontoya Jul 29, 2024
f32afdf
integrated Andres's new container type with covariant solver
tristanmontoya Jul 29, 2024
b5df5c1
Merge remote-tracking branch 'origin/main' into tm/p4est_new_container
tristanmontoya Aug 6, 2024
c5483f3
added flux-differencing kernel for covariant form
tristanmontoya Aug 8, 2024
bab3363
Merge remote-tracking branch 'origin/main' into tm/covariant_flux_dif…
tristanmontoya Aug 15, 2024
bc1da0a
integrated Andrés' PR with covariant solver
tristanmontoya Aug 15, 2024
3d4f809
Merge remote-tracking branch 'origin/main' into tm/covariant_form
tristanmontoya Aug 17, 2024
ae53831
add tests for spherical advection in Cartesian coords
tristanmontoya Aug 17, 2024
eb81ca5
revert change to moist bubble case
tristanmontoya Aug 17, 2024
e9ec616
revert change to moist bubble case
tristanmontoya Aug 17, 2024
e0c6303
Merge branch 'tm/test_spherical_advection' into tm/covariant_form
tristanmontoya Aug 17, 2024
98b0f0e
covariant weak form with tests
tristanmontoya Aug 17, 2024
9799f81
removed shallow water from this branch
tristanmontoya Aug 17, 2024
73dda27
reorganize a bit
tristanmontoya Aug 18, 2024
7de998a
hard-code dimension of node coordinates to avoid type instability
tristanmontoya Aug 20, 2024
317033a
metric terms for shell of radius != 1
tristanmontoya Aug 20, 2024
2fd7610
Merge remote-tracking branch 'origin/tm/test_spherical_advection' int…
tristanmontoya Aug 20, 2024
351eb7a
test for covariant form is now on earth scale
tristanmontoya Aug 21, 2024
add6cc7
fix name of cartesian test
tristanmontoya Aug 22, 2024
e1eb237
moved i,j,element,cache into flux signatures for covariant form
tristanmontoya Sep 1, 2024
c4211d3
added test for flux differencing covariant form
tristanmontoya Sep 1, 2024
2fa4e01
Merge branch 'main' into tm/covariant_form
tristanmontoya Sep 1, 2024
44ac576
transformation between local coordinate systems now uses latitude-lon…
tristanmontoya Sep 4, 2024
73e858a
Merge remote-tracking branch 'origin/main' into tm/covariant_form
tristanmontoya Sep 4, 2024
fc52dfe
format
tristanmontoya Sep 4, 2024
2067837
make compatible with my PR trixi-framework/Trixi.jl#2068
tristanmontoya Sep 7, 2024
808e74c
Merge remote-tracking branch 'origin/tm/p4est_mesh_compat' into tm/co…
tristanmontoya Sep 7, 2024
2d5e6c5
separate containers to store geometric information specific to covari…
tristanmontoya Sep 9, 2024
6d4ae0d
add element-local mapping from Guba et al.
tristanmontoya Sep 10, 2024
bcb9fda
add reference to Guba et al. to docstring
tristanmontoya Sep 10, 2024
f4f94fb
Merge branch 'tm/element_local_mapping' into tm/covariant_form
tristanmontoya Sep 10, 2024
a69b558
new mapping works with cartesian solver solver in covariant_form branch
tristanmontoya Sep 10, 2024
d2cd693
exact metrics for element-local mapping
tristanmontoya Sep 10, 2024
4324e62
streamline tests and improve readability
tristanmontoya Sep 10, 2024
c46d20b
rename default DGSEM mapping
tristanmontoya Sep 10, 2024
937c069
Merge branch 'tm/element_local_mapping' into tm/covariant_form
tristanmontoya Sep 10, 2024
7ff3331
didn't need new analysis cache
tristanmontoya Sep 11, 2024
1248f88
improve comments
tristanmontoya Sep 11, 2024
9504e9c
Merge remote-tracking branch 'origin/main' into tm/covariant_form
tristanmontoya Sep 12, 2024
936dc49
refactor
tristanmontoya Sep 13, 2024
c4adf7c
remove DiffEqCallbacks for now
tristanmontoya Sep 13, 2024
ad0a60e
add better comments
tristanmontoya Sep 14, 2024
4b3642c
improve comments
tristanmontoya Sep 14, 2024
d3bc8f7
better documentation
tristanmontoya Sep 14, 2024
7d7ec99
add NDIMS_AMBIENT parameter to equations
tristanmontoya Sep 15, 2024
e5b3602
Merge remote-tracking branch 'origin/main' into tm/element_local_mapping
tristanmontoya Oct 5, 2024
4de0ca3
fix docstring format
tristanmontoya Oct 5, 2024
4412add
Merge branch 'tm/element_local_mapping' into tm/covariant_form
tristanmontoya Oct 5, 2024
731fa69
make link in docs work
tristanmontoya Oct 5, 2024
ca7118c
fix link in docs
tristanmontoya Oct 5, 2024
7db2950
Merge branch 'tm/element_local_mapping' into tm/covariant_form
tristanmontoya Oct 5, 2024
13fe226
documentation for the covariant solver
tristanmontoya Oct 5, 2024
f8b76ee
added surface central flux and test
tristanmontoya Oct 12, 2024
be033ab
fix trixi_compat
tristanmontoya Oct 12, 2024
87143be
specialize compute_coefficients! to dimension 2
tristanmontoya Oct 12, 2024
b8dc13a
format
tristanmontoya Oct 12, 2024
2b475d5
fix spelling
tristanmontoya Oct 12, 2024
eab59ff
Merge remote-tracking branch 'origin/main' into tm/covariant_form
tristanmontoya Oct 12, 2024
4cc1ec9
remove initial_condition parameter from rhs
tristanmontoya Oct 17, 2024
58ed6a9
Merge remote-tracking branch 'origin/main' into tm/covariant_form
tristanmontoya Nov 4, 2024
fb379e0
no need to use Float32 for physical constant defaults
tristanmontoya Nov 4, 2024
a4d7e4f
incorporate downstream changes
tristanmontoya Nov 4, 2024
9137903
format
tristanmontoya Nov 4, 2024
9333aa6
Merge remote-tracking branch 'origin/main' into tm/covariant_form
tristanmontoya Nov 6, 2024
9e9b3d7
merge changes from PR #36 (work in progress)
tristanmontoya Nov 10, 2024
78f8593
standardize test cases
tristanmontoya Nov 11, 2024
5d71c5a
move covariant form max_dt method to callbacks_step
tristanmontoya Nov 11, 2024
4f1b3dc
Fix comments
tristanmontoya Nov 11, 2024
0f0a8e7
generalize interface between equations and cache
tristanmontoya Nov 11, 2024
6d11443
relax relative tolerance on cartesian advection test)
tristanmontoya Nov 11, 2024
d515349
improve docs
tristanmontoya Nov 12, 2024
90fa2a6
streamline initial condition definition and improve docs
tristanmontoya Nov 13, 2024
b7a7f5a
tests for cartesian form now use standard and element-local mapping a…
tristanmontoya Nov 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove initial_condition parameter from rhs
tristanmontoya committed Oct 17, 2024
commit 4cc1ec9a65af54afec440b94c18dff5039e017d2
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -23,5 +23,5 @@ Static = "0.8, 1"
StaticArrayInterface = "1.5.1"
StaticArrays = "1"
StrideArrays = "0.1.28"
Trixi = "0.7, 0.8, 0.9"
Trixi = "0.9"
julia = "1.9"
2 changes: 1 addition & 1 deletion src/solvers/dgsem_p4est/dg_2d_manifold_in_3d_covariant.jl
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@
# not yet support non-conforming meshes for the covariant solver.
function Trixi.rhs!(du, u, t, mesh::P4estMesh{2},
equations::AbstractCovariantEquations{2},
initial_condition, boundary_conditions, source_terms::Source,
boundary_conditions, source_terms::Source,
dg::DG, cache) where {Source}
# Reset du
Trixi.@trixi_timeit Trixi.timer() "reset ∂u/∂t" Trixi.reset_du!(du, dg, cache)