Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D Cartesian Shallow Water Equations #36

Merged
merged 20 commits into from
Nov 8, 2024
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
368b91e
Added curl invariant metrics
amrueda Sep 16, 2024
56a04d0
Fixed specialization of create_cache for semidiscretization_hyperbolic
amrueda Sep 17, 2024
3f78c43
Specialized the computation of the time-step size for 3D equations in…
amrueda Sep 17, 2024
6307055
Updated test results and formatted
amrueda Sep 17, 2024
d39bb66
Added 3D Cartesian Shallow Water equations and entropy-consistent dis…
amrueda Sep 17, 2024
a6c5ec9
Fixed the computation of the metric terms for 2D manifolds in 3D with…
amrueda Sep 17, 2024
e16e866
Added test for 3D Cartesian Shallow Water Equations
amrueda Sep 17, 2024
16b8034
Use Fjordholm flux in EC through correction test to improve coverage
amrueda Sep 17, 2024
a6cd055
Changes to fix the Documenter action
amrueda Sep 17, 2024
111fa45
Fixed equation renderung for documenter and removed max_abs_speed_nai…
amrueda Sep 17, 2024
b13d5c9
Merge branch 'main' into arr/spherical_shallow_water_es
amrueda Nov 4, 2024
37ef0bf
Merge branch 'main' into arr/spherical_shallow_water_es
amrueda Nov 6, 2024
ea64024
Changed name of MetricTermsCurlInvariant to MetricTermsInvariantCurl …
amrueda Nov 6, 2024
23e46bd
Updated test reference results (due to new time-step size routine)
amrueda Nov 6, 2024
8a9ef3d
Moved the Lagrange multiplier functions to shallow_water_3d.jl and im…
amrueda Nov 7, 2024
9ef87f7
Removed the custom rhs routine from the Cartesian spherical shell eli…
amrueda Nov 7, 2024
58aa42b
Apply suggestions from code review
amrueda Nov 8, 2024
9bb4970
Adapted elixirs to new variables that are exported by TrixiAtmo
amrueda Nov 8, 2024
be72d3e
Merge branch 'main' into arr/spherical_shallow_water_es
amrueda Nov 8, 2024
7a42b0f
Format
amrueda Nov 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adapted elixirs to new variables that are exported by TrixiAtmo
amrueda committed Nov 8, 2024
commit 9bb4970c409826d857b50fd4384800369e82228e
6 changes: 3 additions & 3 deletions examples/elixir_euler_spherical_advection_cartesian.jl
Original file line number Diff line number Diff line change
@@ -75,9 +75,9 @@ initial_condition = initial_condition_advection_sphere

element_local_mapping = false

mesh = TrixiAtmo.P4estMeshCubedSphere2D(5, 1.0, polydeg = polydeg,
initial_refinement_level = 0,
element_local_mapping = element_local_mapping)
mesh = P4estMeshCubedSphere2D(5, 1.0, polydeg = polydeg,
initial_refinement_level = 0,
element_local_mapping = element_local_mapping)

# A semidiscretization collects data structures and functions for the spatial discretization
semi = SemidiscretizationHyperbolic(mesh, equations, initial_condition, solver,
Original file line number Diff line number Diff line change
@@ -77,12 +77,12 @@ end

initial_condition = initial_condition_advection_sphere

mesh = TrixiAtmo.P4estMeshCubedSphere2D(5, 2.0, polydeg = polydeg,
initial_refinement_level = 0)
mesh = P4estMeshCubedSphere2D(5, 2.0, polydeg = polydeg,
initial_refinement_level = 0)

# A semidiscretization collects data structures and functions for the spatial discretization
semi = SemidiscretizationHyperbolic(mesh, equations, initial_condition, solver,
metric_terms = TrixiAtmo.MetricTermsInvariantCurl(),
metric_terms = MetricTermsInvariantCurl(),
source_terms = source_terms_entropy_correction)

###############################################################################
Original file line number Diff line number Diff line change
@@ -59,12 +59,12 @@ end

initial_condition = initial_condition_advection_sphere

mesh = TrixiAtmo.P4estMeshCubedSphere2D(5, 2.0, polydeg = polydeg,
initial_refinement_level = 0)
mesh = P4estMeshCubedSphere2D(5, 2.0, polydeg = polydeg,
initial_refinement_level = 0)

# A semidiscretization collects data structures and functions for the spatial discretization
semi = SemidiscretizationHyperbolic(mesh, equations, initial_condition, solver,
metric_terms = TrixiAtmo.MetricTermsInvariantCurl(),
metric_terms = MetricTermsInvariantCurl(),
source_terms = source_terms_lagrange_multiplier)

###############################################################################
4 changes: 2 additions & 2 deletions examples/elixir_shallowwater_cubed_sphere_shell_standard.jl
Original file line number Diff line number Diff line change
@@ -62,8 +62,8 @@ end

initial_condition = initial_condition_advection_sphere

mesh = TrixiAtmo.P4estMeshCubedSphere2D(5, 2.0, polydeg = polydeg,
initial_refinement_level = 0)
mesh = P4estMeshCubedSphere2D(5, 2.0, polydeg = polydeg,
initial_refinement_level = 0)

# A semidiscretization collects data structures and functions for the spatial discretization
semi = SemidiscretizationHyperbolic(mesh, equations, initial_condition, solver,