-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation message with MPI extension #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this work (untried) and is not too dirrrty?
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 93.65% 94.36% +0.71%
==========================================
Files 4 4
Lines 63 71 +8
==========================================
+ Hits 59 67 +8
Misses 4 4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! If @efaulhaber approves, this can be merged imho (don't mind the missing format check, that's dependent on another PR be to merged)
test/test_util.jl
Outdated
it is not empty and ignores some common info statements printed in Trixi.jl | ||
uses. | ||
""" | ||
macro test_nowarn_mod(expr, additional_ignore_content=String[]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we somehow export this as well when importing TrixiBase from a testing environment? Then we can avoid duplicating this function from Trixi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@efaulhaber Maybe we can move this convo to a separate issue such that we can merge this PR (once you approve) and then start the registration process?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to move this macro to the plain source code of the package and make TrixiBase.jl depend on Test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the default
ignore_content = Any["[ Info: You just called `trixi_include`. Julia may now compile the code, please be patient.\n"]
set below will likely also depend on the specific package we're using. For example, we have more stuff in Trixi.jl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there is no nice way to do it? Maybe add Test as a soft dependency or so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @sloede said, I'm fine discussing this further in an issue and merging this soon to start the registration process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to prefer moving this to a TrixiTest.jl package to avoid depending on Test etc. everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to #9. Your points are absolutely valid @efaulhaber, I just wanted to make sure we can move forward with the current state.
@ranocha I think the error message is not yet properly filtered out: |
Pull Request Test Coverage Report for Build 7726527485
💛 - Coveralls |
Should be fixed |
I wanted to draft a version with a package extension for MPI so that we can still include the info message
However, the first naive approach doesn't work nicely since we're not allowed to overwrite method definitions while precompiling. Thus, I needed to deactivate precompilation for the extension, resulting in the ugly messages
We can not use something in
__init__
since that will be called before Trixi.jl is initialized - i.e., before MPI is initialized in general.