Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate format check #6

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Separate format check #6

merged 5 commits into from
Jan 29, 2024

Conversation

sloede
Copy link
Member

@sloede sloede commented Jan 29, 2024

Resolves #4.

@sloede sloede requested review from ranocha and efaulhaber January 29, 2024 15:08
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e8161a) 93.65% compared to head (44a16f9) 88.52%.

❗ Current head 44a16f9 differs from pull request most recent head 72b600a. Consider uploading reports for the commit 72b600a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   93.65%   88.52%   -5.13%     
==========================================
  Files           4        4              
  Lines          63       61       -2     
==========================================
- Hits           59       54       -5     
- Misses          4        7       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/FormatCheck.yml Outdated Show resolved Hide resolved
.github/workflows/FormatCheck.yml Outdated Show resolved Hide resolved
.github/workflows/FormatCheck.yml Show resolved Hide resolved
@ranocha ranocha requested a review from efaulhaber January 29, 2024 15:31
@sloede sloede requested a review from ranocha January 29, 2024 15:33
@sloede sloede enabled auto-merge (squash) January 29, 2024 15:35
Copy link

github-actions bot commented Jan 29, 2024

Pull Request Test Coverage Report for Build 7698722990

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.651%

Totals Coverage Status
Change from base Build 7698633312: 0.0%
Covered Lines: 59
Relevant Lines: 63

💛 - Coveralls

@sloede
Copy link
Member Author

sloede commented Jan 29, 2024

@efaulhaber it would be great to get your approval as well such that the auto-merge cna go ahead

@sloede sloede disabled auto-merge January 29, 2024 15:50
@sloede sloede merged commit c69be7f into main Jan 29, 2024
13 checks passed
@sloede sloede deleted the msl/separate-format-check branch January 29, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format error shouldn't prevent tests from running
3 participants