Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user when choosing wrong wall viscosity model #445

Merged
merged 8 commits into from
Mar 20, 2024

Conversation

LasNikas
Copy link
Collaborator

@LasNikas LasNikas commented Mar 6, 2024

Allow ArtificialViscosityMonaghan as wall viscosity model but print out warning.
(Otherwise it prints weird cache errors when accidentally choosing the wrong viscosity model

As we can see, it would work...
image

@LasNikas LasNikas added this to the 0.1 milestone Mar 6, 2024
@LasNikas LasNikas requested review from svchb and efaulhaber March 6, 2024 10:46
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 70.57%. Comparing base (6fbb010) to head (d6712db).
Report is 1 commits behind head on main.

Files Patch % Lines
src/schemes/boundary/system.jl 0.00% 2 Missing ⚠️
src/schemes/fluid/viscosity.jl 0.00% 2 Missing ⚠️
...chemes/boundary/dummy_particles/dummy_particles.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   70.57%   70.57%           
=======================================
  Files          66       66           
  Lines        3827     3827           
=======================================
  Hits         2701     2701           
  Misses       1126     1126           
Flag Coverage Δ
unit 70.57% <37.50%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/schemes/boundary/system.jl Outdated Show resolved Hide resolved
@LasNikas LasNikas requested review from efaulhaber and svchb March 7, 2024 07:06
@svchb svchb enabled auto-merge (squash) March 19, 2024 11:26
@svchb svchb merged commit 1ca7fff into trixi-framework:main Mar 20, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants