Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise custom quantities #457

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

efaulhaber
Copy link
Member

No description provided.

@efaulhaber efaulhaber requested review from svchb and LasNikas March 10, 2024 19:59
@efaulhaber efaulhaber added this to the 0.1 milestone Mar 10, 2024
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 70.67%. Comparing base (ba73913) to head (74fda84).

Files Patch % Lines
src/general/custom_quantities.jl 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   70.82%   70.67%   -0.15%     
==========================================
  Files          66       66              
  Lines        3808     3816       +8     
==========================================
  Hits         2697     2697              
- Misses       1111     1119       +8     
Flag Coverage Δ
unit 70.67% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

svchb
svchb previously approved these changes Mar 11, 2024
src/general/custom_quantities.jl Outdated Show resolved Hide resolved
@efaulhaber efaulhaber requested a review from LasNikas March 12, 2024 17:04
@efaulhaber efaulhaber enabled auto-merge (squash) March 12, 2024 17:18
@efaulhaber efaulhaber merged commit 01e4c9a into trixi-framework:main Mar 12, 2024
7 of 9 checks passed
@efaulhaber efaulhaber deleted the revise-custom-quantities branch May 29, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants