Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Morris surface tension model #584

Open
wants to merge 409 commits into
base: main
Choose a base branch
from

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented Jul 29, 2024

Depends on #539
Depends on #604
Depends on #605
Depends on #606
Depends on #607
Depends on #608
Depends on #609
Depends on #599
super seeds #523

@svchb svchb marked this pull request as draft July 29, 2024 12:54
@svchb svchb added the enhancement New feature or request label Jul 29, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 59.04139% with 188 lines in your changes missing coverage. Please review.

Project coverage is 69.08%. Comparing base (f051b55) to head (cfe7626).

Files with missing lines Patch % Lines
src/schemes/fluid/surface_normal_sph.jl 44.50% 96 Missing ⚠️
src/visualization/write2vtk.jl 0.00% 28 Missing ⚠️
src/schemes/fluid/surface_tension.jl 20.00% 24 Missing ⚠️
...rc/schemes/fluid/entropically_damped_sph/system.jl 50.00% 10 Missing ⚠️
src/schemes/fluid/fluid.jl 44.44% 10 Missing ⚠️
...rc/schemes/fluid/weakly_compressible_sph/system.jl 72.72% 6 Missing ⚠️
src/general/semidiscretization.jl 72.22% 5 Missing ⚠️
src/schemes/boundary/system.jl 87.50% 4 Missing ⚠️
src/general/system.jl 66.66% 2 Missing ⚠️
src/schemes/boundary/boundary.jl 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   68.51%   69.08%   +0.56%     
==========================================
  Files          87       90       +3     
  Lines        5406     5793     +387     
==========================================
+ Hits         3704     4002     +298     
- Misses       1702     1791      +89     
Flag Coverage Δ
unit 69.08% <59.04%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svchb svchb mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants