feat(jsonrpc): ethGetBlockByNumber supports finalized #6007
+48
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joj501
approved these changes
Nov 13, 2024
| fromBlockSrc = JsonRpcApiUtil.getByJsonBlockId(fr.getFromBlock()); | ||
| toBlockSrc = JsonRpcApiUtil.getByJsonBlockId(fr.getToBlock()); | ||
| fromBlockSrc = JsonRpcApiUtil.getByJsonBlockId(fr.getFromBlock(), wallet); | ||
| toBlockSrc = JsonRpcApiUtil.getByJsonBlockId(fr.getToBlock(), wallet); |
317787106
reviewed
Nov 15, 2024
| @@ -51,15 +51,15 @@ public LogFilterWrapper(FilterRequest fr, long currentMaxBlockNum, Wallet wallet | |||
| // then if toBlock < maxBlockNum, set fromBlock = toBlock | |||
| // then if toBlock >= maxBlockNum, set fromBlock = maxBlockNum | |||
| if (StringUtils.isEmpty(fr.getFromBlock()) && StringUtils.isNotEmpty(fr.getToBlock())) { | |||
| toBlockSrc = JsonRpcApiUtil.getByJsonBlockId(fr.getToBlock()); | |||
There was a problem hiding this comment.
The method public static long getByJsonBlockId(String blockNumOrTag) is only used in LogFilterWrapper, and it should not support finalized. So it should throw new JsonRpcInvalidParamsException("TAG finalized not supported");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
make ethGetBlockByNumber supports finalized
Why are these changes required?
For many developers, they need to get the latest solidified/finalized block number, then fetch other data by this number.
For more details, visit issue #5953
This PR has been tested by:
Follow up
Extra details