Fix issue #172 with tempnam() throwing an Exception. #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a Homestead server setup on my Windows PC for development and so my temp directory is not "/tmp" and Laravel throws an ErrorException. The `sys_get_temp_dir()` function returns the default path PHP stores temporary files in. So it will still resolve to `"/tmp"` on Linux, but for Windows it will resolve to the correct temp directory.
|
Another option could be to allow the value to be modified through the configuration. |
|
According to #158, it would be better if we didn't even use a cookie file as they currently are not auto-cleaned up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a Homestead server setup on my Windows PC for Laravel development.
When I run a command in my local CLI that calls PHRETS I get an error exception because Window's temporary directory is not "/tmp."
Using
sys_get_temp_dir()will return the correct path for PHP's temporary file store for the current environment. On Linux it will still be/tmp.