Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor user's CFLAGS #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Honor user's CFLAGS #191

wants to merge 1 commit into from

Conversation

noloader
Copy link

The project's required CFLAGS are gathered in UTH_CFLAGS and used in the target recipes. It leaves CFLAGS for the user. Also see https://www.gnu.org/prep/standards/html_node/Command-Variables.html.

The project's required CFLAGS are gathered in UTH_CFLAGS and used in the target recipes. It leaves CFLAGS for the user. Also see https://www.gnu.org/prep/standards/html_node/Command-Variables.html
@Quuxplusone
Copy link
Collaborator

This seems reasonable; I like the guidelines in https://www.gnu.org/prep/standards/html_node/Command-Variables.html . However:

  • this now needs rebasing (thanks for reminding me to merge the no-more-murmurhash patch!)
  • if we're putting the user's CFLAGS at the end of the line, then should we put the user's CPPFLAGS (preprocessor flags) at the end of the line as well?
  • s/UTH_CFLAGS/HASH_CFLAGS/ — let's keep the number of prefixes we use to a minimum

UTH_CFLAGS += -Wall
#UTH_CFLAGS += -Wextra
#UTH_CFLAGS += -std=c89
UTH_CFLAGS += ${EXTRA_CFLAGS}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my high-level comments in the "Conversation" tab: should this now use ${CFLAGS} instead of ${EXTRA_CFLAGS}? I believe the purpose of EXTRA_CFLAGS was so that the user can pass their own extra stuff, but if we're going to respect their CFLAGS then they don't need this extra mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants