Fix potentially undefined local variables (#251)

backend/migration/qdrant_migration.py

@@ -72,6 +72,7 @@ def migrate_collection(
     except Exception as e:
         raise e
 
+    dest_collection = None
     try:
         # prepare collection to be created at destination
         dest_collection = CreateCollectionDto(
@@ -130,11 +131,12 @@ def migrate_collection(
         )
 
     except Exception as e:
-        with requests.delete(
-            url=f"{destination_backend_url.rstrip('/')}/v1/collections/{destination_collection_name}",
-            json=dest_collection,
-        ) as r:
-            logger.debug("Destination collection entry deleted: ", r.json())
+        if dest_collection is not None:
+            with requests.delete(
+                url=f"{destination_backend_url.rstrip('/')}/v1/collections/{destination_collection_name}",
+                json=dest_collection,
+            ) as r:
+                logger.debug("Destination collection entry deleted: ", r.json())
         raise e
 
     logger.debug(

backend/migration/utils.py

@@ -47,9 +47,8 @@ def migrate(
         dest_client (QdrantBase): Destination client
         source_collection_name (str): source collection names to migrate.
         destination_collection_name (str): destination collection name.
-        recreate_on_collision (bool, optional): If True - recreate collection if it exists, otherwise
-            raise ValueError.
         batch_size (int, optional): Batch size for scrolling and uploading vectors. Defaults to 100.
+        same_qdrant (bool, optional): If both source and dest client point to same qdrant
     """
     if _has_custom_shards(source_client, source_collection_name):
         raise ValueError(

backend/modules/dataloaders/truefoundryloader.py

@@ -50,6 +50,9 @@ def load_filtered_data(
             download_info = dataset.download(path=dest_dir)
             logger.debug(f"Data directory download info: {download_info}")
 
+        else:
+            raise ValueError(f"Unsupported data_source uri type {data_source.uri}")
+
         if download_info:
             if os.path.exists(os.path.join(download_info, "files")):
                 logger.debug("Files directory exists")

backend/modules/parsers/multimodalparser.py

@@ -145,15 +145,14 @@ async def get_chunks(
         """
         Asynchronously extracts text from a PDF file and returns it in chunks.
         """
-
+        final_texts = []
         try:
             if not filepath.endswith(".pdf"):
                 logger.error(
                     "Invalid file extension. MultiModalParser only supports PDF files."
                 )
                 return []
 
-            final_texts = list()
             # Open the PDF file using pdfplumber
             doc = fitz.open(filepath)
 
@@ -164,12 +163,12 @@ async def get_chunks(
             # Iterate over each page in the PDF
             logger.info(f"\n\nLoading all pages...")
             for page in doc:
+                page_number = page.number + 1
                 try:
-                    page_number = page.number + 1
                     # Convert the page to an image (RGB mode)
                     pix = page.get_pixmap(alpha=False)
                     img = np.frombuffer(pix.samples, dtype=np.uint8).reshape(
-                        pix.h, pix.w, pix.n
+                        (pix.h, pix.w, pix.n)
                     )
 
                     # Convert the image to base64

backend/modules/query_controllers/multimodal/controller.py

@@ -166,6 +166,8 @@ def _get_multi_query_retriever(
             base_retriever = self._get_contextual_compression_retriever(
                 vector_store, retriever_config
             )
+        else:
+            raise ValueError(f"Unknown retriever_type {retriever_type}")
 
         return MultiQueryRetriever.from_llm(
             retriever=base_retriever,

backend/server/decorators.py

@@ -109,7 +109,6 @@ def query_controller(tag: str = None):
 
     Args:
         tag (str, optional): The tag to use for OpenAPI documentation.
-        prefix (str, optional): The prefix to use for all routes.
 
     Returns:
         class: The decorated class.