Skip to content

Commit

Permalink
Technical/Switch to truemail-rspec (#59)
Browse files Browse the repository at this point in the history
  • Loading branch information
bestwebua authored Nov 20, 2019
1 parent f0566ba commit 5348f97
Show file tree
Hide file tree
Showing 17 changed files with 622 additions and 920 deletions.
7 changes: 5 additions & 2 deletions .overcommit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@ PreCommit:
BundleAudit:
enabled: true

Brakeman:
Fasterer:
enabled: true
include: '**/*.rb'

TrailingWhitespace:
enabled: true
flags: ['--exit-on-warn', '--quiet', '--summary']

RuboCop:
enabled: true
Expand Down
31 changes: 29 additions & 2 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
require:
- rubocop-rspec
- rubocop-performance

AllCops:
DisplayCopNames: true
DisplayStyleGuide: true
Expand All @@ -19,7 +23,7 @@ Metrics/CyclomaticComplexity:
Metrics/PerceivedComplexity:
Enabled: false

Documentation:
Style/Documentation:
Enabled: false

Style/DoubleNegation:
Expand All @@ -31,7 +35,27 @@ Style/EmptyCaseCondition:
Style/RescueStandardError:
Enabled: false

require: rubocop-rspec
Layout/ClassStructure:
Enabled: true
Categories:
module_inclusion:
- include
- prepend
- extend
associations:
- has_one
- has_many
- belongs_to
- has_and_belongs_to_many
ExpectedOrder:
- module_inclusion
- constants
- associations
- public_class_methods
- initializer
- public_methods
- protected_methods
- private_methods

RSpec/ExampleLength:
Enabled: false
Expand All @@ -53,3 +77,6 @@ RSpec/AnyInstance:

RSpec/MessageSpies:
Enabled: false

RSpec/MultipleDescribes:
Enabled: false
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
# Changelog
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.4.1] - 2019-11-20
### Changed
- gem development dependencies
- linters configs
- gem documentation

### Removed
- truemail rspec helpers (moved to independent gem [`truemail-rspec`](https://github.com/truemail-rb/truemail-rspec))

## [1.4.0] - 2019-10-28
### Added
- Event logger (ability to output validation logs to stdout/file)
Expand Down
84 changes: 47 additions & 37 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
truemail (1.4.0)
truemail (1.4.1)

GEM
remote: https://rubygems.org/
Expand All @@ -14,37 +14,38 @@ GEM
bundler-audit (0.6.1)
bundler (>= 1.2.0, < 3)
thor (~> 0.18)
byebug (11.0.0)
childprocess (0.9.0)
ffi (~> 1.0, >= 1.0.11)
byebug (11.0.1)
childprocess (3.0.0)
codeclimate-engine-rb (0.4.1)
virtus (~> 1.0)
coderay (1.1.2)
coercible (1.0.0)
descendants_tracker (~> 0.0.1)
colorize (0.8.1)
descendants_tracker (0.0.4)
thread_safe (~> 0.3, >= 0.3.1)
diff-lcs (1.3)
docile (1.3.1)
docile (1.3.2)
equalizer (0.0.11)
ffaker (2.10.0)
ffi (1.10.0)
fasterer (0.8.0)
colorize (~> 0.7)
ruby_parser (>= 3.14.1)
ffaker (2.13.0)
ice_nine (0.11.2)
iniparse (1.4.4)
jaro_winkler (1.5.2)
jaro_winkler (1.5.4)
json (2.2.0)
json_matchers (0.11.1)
json_schema
json_schema (0.20.8)
kwalify (0.7.2)
method_source (0.9.2)
overcommit (0.46.0)
childprocess (~> 0.6, >= 0.6.3)
overcommit (0.51.0)
childprocess (>= 0.6.3, < 4)
iniparse (~> 1.4)
parallel (1.14.0)
parser (2.6.0.0)
parallel (1.19.0)
parser (2.6.5.0)
ast (~> 2.4.0)
powerpack (0.1.2)
pry (0.12.2)
coderay (~> 1.1.0)
method_source (~> 0.9.0)
Expand All @@ -53,8 +54,8 @@ GEM
pry (~> 0.10)
psych (3.1.0)
rainbow (3.0.0)
rake (12.3.2)
reek (5.3.1)
rake (13.0.1)
reek (5.5.0)
codeclimate-engine-rb (~> 0.4.0)
kwalify (~> 0.7.0)
parser (>= 2.5.0.0, < 2.7, != 2.5.1.1)
Expand All @@ -73,26 +74,32 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.9.0)
rspec-support (3.9.0)
rubocop (0.65.0)
rubocop (0.76.0)
jaro_winkler (~> 1.5.1)
parallel (~> 1.10)
parser (>= 2.5, != 2.5.1.1)
powerpack (~> 0.1)
psych (>= 3.1.0)
parser (>= 2.6)
rainbow (>= 2.2.2, < 4.0)
ruby-progressbar (~> 1.7)
unicode-display_width (~> 1.4.0)
rubocop-rspec (1.32.0)
rubocop (>= 0.60.0)
ruby-progressbar (1.10.0)
simplecov (0.16.1)
unicode-display_width (>= 1.4.0, < 1.7)
rubocop-performance (1.5.1)
rubocop (>= 0.71.0)
rubocop-rspec (1.36.0)
rubocop (>= 0.68.1)
ruby-progressbar (1.10.1)
ruby_parser (3.14.1)
sexp_processor (~> 4.9)
sexp_processor (4.13.0)
simplecov (0.17.1)
docile (~> 1.1)
json (>= 1.8, < 3)
simplecov-html (~> 0.10.0)
simplecov-html (0.10.2)
thor (0.20.3)
thread_safe (0.3.6)
unicode-display_width (1.4.1)
truemail-rspec (0.1.0)
rspec (~> 3.0)
truemail (~> 1.4)
unicode-display_width (1.6.0)
virtus (1.0.5)
axiom-types (~> 0.1)
coercible (~> 1.0)
Expand All @@ -104,18 +111,21 @@ PLATFORMS

DEPENDENCIES
bundler (~> 1.16)
bundler-audit
ffaker
json_matchers
overcommit
pry-byebug
rake
reek
rspec
rubocop
rubocop-rspec
simplecov
bundler-audit (~> 0.6.1)
fasterer (~> 0.8.0)
ffaker (~> 2.13)
json_matchers (~> 0.11.1)
overcommit (~> 0.51.0)
pry-byebug (~> 3.7)
rake (~> 13.0, >= 13.0.1)
reek (~> 5.5)
rspec (~> 3.9)
rubocop (~> 0.76.0)
rubocop-performance (~> 1.5, >= 1.5.1)
rubocop-rspec (~> 1.36)
simplecov (~> 0.17.1)
truemail!
truemail-rspec (~> 0.1.0)

BUNDLED WITH
1.17.3
1.16.6
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ The Truemail gem helps you validate emails via regex pattern, presence of DNS re
- [Truemail helpers](#truemail-helpers)
- [.valid?](#valid)
- [Test environment](#test-environment)
- [Truemail family](#truemail-family)
- [Contributing](#contributing)
- [License](#license)
- [Code of Conduct](#code-of-conduct)
Expand Down Expand Up @@ -948,6 +949,14 @@ end
```

---
## Truemail family

All Truemail extensions: https://github.com/truemail-rb

### truemail-rspec

gem `truemail-rspec` - Truemail configuration and validator RSpec helpers, https://github.com/truemail-rb/truemail-rspec

## Contributing

Bug reports and pull requests are welcome on GitHub at https://github.com/rubygarage/truemail. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct. Please check the [open tikets](https://github.com/rubygarage/truemail/issues). Be shure to follow Contributor Code of Conduct below and our [Contributing Guidelines](CONTRIBUTING.md).
Expand Down
2 changes: 1 addition & 1 deletion lib/truemail/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module Truemail
VERSION = '1.4.0'
VERSION = '1.4.1'
end
4 changes: 2 additions & 2 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
require 'json_matchers/rspec'
require 'pry'
require 'truemail'
require 'truemail/rspec'

SimpleCov.start
JsonMatchers.schema_root = 'spec/support/schemas'
Expand All @@ -16,8 +17,7 @@
end

RSpec.configure do |config|
config.include Truemail::ConfigurationHelper
config.include Truemail::ValidatorHelper
config.include Truemail::RSpec
config.example_status_persistence_file_path = '.rspec_status'
config.disable_monkey_patching!
config.expect_with(:rspec) { |c| c.syntax = :expect }
Expand Down
18 changes: 0 additions & 18 deletions spec/support/helpers/configuration_helper.rb

This file was deleted.

43 changes: 0 additions & 43 deletions spec/support/helpers/configuration_helper_spec.rb

This file was deleted.

Loading

0 comments on commit 5348f97

Please sign in to comment.