-
-
Notifications
You must be signed in to change notification settings - Fork 64
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Technical/Update gem dependencies (#104)
* Updated Truemail::RegexConstant::REGEX_EMAIL_PATTERN * Updated gem development dependencies * Updated linter config * Updated gem version, changelog, documentation
- Loading branch information
Showing
16 changed files
with
237 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ checks: | |
plugins: | ||
rubocop: | ||
enabled: true | ||
channel: rubocop-0-93 | ||
channel: rubocop-1-3 | ||
|
||
reek: | ||
enabled: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# Branch naming convention | ||
|
||
## Branch naming | ||
|
||
> Please note for new pull requests create new branches from current `develop` branch only. | ||
Branch name should include type of your contribution and context. Please follow next pattern for naming your branches: | ||
|
||
```bash | ||
feature/add-some-feature | ||
technical/some-technical-improvements | ||
bugfix/fix-some-bug-name | ||
``` | ||
|
||
## Before PR actions | ||
|
||
### Squash commits | ||
|
||
Please squash all branch commits into the one before openning your PR from your fork. It's simple to do with the git: | ||
|
||
```bash | ||
git rebase -i [hash your first commit of your branch]~1 | ||
git rebase -i 6467fe36232401fa740af067cfd8ac9ec932fed2~1 # example | ||
``` | ||
|
||
### Add commit description | ||
|
||
Please complete your commit description folowing next pattern: | ||
|
||
``` | ||
Technical/Add info files # should be the same name as your branch name | ||
* Added license, changelog, contributing, code of conduct docs | ||
* Added GitHub templates | ||
* Updated project license link | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
--- | ||
name: Bug report | ||
about: Create a report to help us improve | ||
title: [BUG] | ||
labels: bug | ||
assignees: bestwebua | ||
|
||
--- | ||
|
||
<!-- Thanks for helping to make Truemail better! Before submit your bug, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) --> | ||
|
||
### New bug checklist | ||
|
||
- [ ] I have updated `truemail` to the latest version | ||
- [ ] I have read the [Contribution Guidelines](https://github.com/truemail-rb/truemail/blob/master/CONTRIBUTING.md) | ||
- [ ] I have read the [documentation](https://truemail-rb.org/truemail-gem) | ||
- [ ] I have searched for [existing GitHub issues](https://github.com/truemail-rb/truemail/issues) | ||
|
||
### Bug description | ||
<!-- Please include what's happening, expected behavior, and any relevant code samples --> | ||
|
||
##### Complete output when running truemail, including the stack trace and command used | ||
|
||
<details> | ||
<pre>[INSERT OUTPUT HERE]</pre> | ||
</details> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for Truemail | ||
title: [FEATURE] | ||
labels: enhancement | ||
assignees: bestwebua | ||
|
||
--- | ||
|
||
<!-- Thanks for helping to make Truemail better! Before submit your new feature request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) --> | ||
|
||
### New feature request checklist | ||
|
||
- [ ] I have updated `truemail` to the latest version | ||
- [ ] I have read the [Contribution Guidelines](https://github.com/truemail-rb/truemail/blob/master/CONTRIBUTING.md) | ||
- [ ] I have read the [documentation](https://truemail-rb.org/truemail-gem) | ||
- [ ] I have searched for [existing GitHub issues](https://github.com/truemail-rb/truemail/issues) | ||
|
||
### Feature description | ||
|
||
<!-- Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] | ||
Describe the solution you'd like. A clear and concise description of what you want to happen. | ||
Describe alternatives you've considered. A clear and concise description of any alternative solutions or features you've considered. --> |
15 changes: 12 additions & 3 deletions
15
.github/ISSUE_TEMPLATE.md → .github/ISSUE_TEMPLATE/issue_report.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
name: Question | ||
about: Ask your question to Truemail team | ||
title: [QUESTION] | ||
labels: question | ||
assignees: bestwebua | ||
|
||
--- | ||
|
||
<!-- Thanks for helping to make Truemail better! Before submit your question, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) --> | ||
|
||
### New question checklist | ||
|
||
- [ ] I have read the [Contribution Guidelines](https://github.com/truemail-rb/truemail/blob/master/CONTRIBUTING.md) | ||
- [ ] I have read the [documentation](https://truemail-rb.org/truemail-gem) | ||
- [ ] I have searched for [existing GitHub issues](https://github.com/truemail-rb/truemail/issues) | ||
|
||
### Question | ||
|
||
<!-- Your question context here --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.