Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update casing on variable names #27

Closed
wants to merge 1 commit into from
Closed

update casing on variable names #27

wants to merge 1 commit into from

Conversation

stavros-k
Copy link
Contributor

Updates casing on variable names to keep everything consistent.

We probably also update the $refs (eg normalize/ixVolume to normalize/ix_volume)

@stavros-k stavros-k requested a review from sonicaj July 2, 2024 13:49
@sonicaj sonicaj requested a review from Qubad786 July 3, 2024 07:53
Qubad786
Qubad786 reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@Qubad786 Qubad786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change will be quite more involved as we would have to rename the features as well to account for this - is it okay if i take over and push a new PR ?

@stavros-k
Copy link
Contributor Author

Yes feel free!

@Qubad786 Qubad786 closed this Jul 8, 2024
@Qubad786 Qubad786 deleted the casing branch July 8, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qubad786 Qubad786 Qubad786 left review comments

@sonicaj sonicaj Awaiting requested review from sonicaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stavros-k @Qubad786