NAS-130170 / 24.10 / Fix node_ip feature #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
1 similar comment
Qubad786
force-pushed
the
mrehan/ip-feature
branch
from
f88617d
to
834bcf6
Compare
Qubad786
force-pushed
the
mrehan/ip-feature
branch
from
834bcf6
to
322867f
Compare
stavros-k
approved these changes
Jul 23, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Remove
validations/node_portfeature as it's not being used anymore anddefinitions/portalready automatically enforces that unused ports get consumed.Adjust node ip ref to actually show all the ips available on the host which the app can bind to.